-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phase_took documentation #5154
phase_took documentation #5154
Conversation
Signed-off-by: David Zane <davizane@amazon.com>
@dzane17 - Is this related to a new feature, say, in 2.11? Or is it just missing content from a previous release? Thanks. |
@hdhalter This is a new feature in 2.11 or 2.12. I added the PR in the description |
Thanks! I added the 2.12 label. Can you please add the dev issue to the unified project? |
@hdhalter Done ✅ |
@hdhalter @dzane17 Are these changes to be merged for 2.12 documentation? Or, do they need to be backported to 2.11 documentation? If these changes need to be applied to 2.11 documentation, then we need to remove the Once the changes go through doc review (that is, content review by a technical writer), the doc reviewer will approve the changes, and then @dzane17 can merge this PR. visibility cc: @kolchfa-aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Suggested rewording for clarity. Thanks, @dzane17!
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: David Z <38449481+dzane17@users.noreply.github.com>
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: David Z <38449481+dzane17@users.noreply.github.com>
@vagimeli 2.12 is correct @kolchfa-aws Updated the wording. Thanks for the suggestions |
* phase_took documentation Signed-off-by: David Zane <davizane@amazon.com> * Update _api-reference/cluster-api/cluster-settings.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: David Z <38449481+dzane17@users.noreply.github.com> * Update _api-reference/search.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: David Z <38449481+dzane17@users.noreply.github.com> --------- Signed-off-by: David Zane <davizane@amazon.com> Signed-off-by: David Z <38449481+dzane17@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
* phase_took documentation Signed-off-by: David Zane <davizane@amazon.com> * Update _api-reference/cluster-api/cluster-settings.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: David Z <38449481+dzane17@users.noreply.github.com> * Update _api-reference/search.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: David Z <38449481+dzane17@users.noreply.github.com> --------- Signed-off-by: David Zane <davizane@amazon.com> Signed-off-by: David Z <38449481+dzane17@users.noreply.github.com> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Description
Added documentation for:
phase_took
_search api request parametersearch.phase_took_enabled
cluster settingOpenSearch PR: opensearch-project/OpenSearch#10351
GitHub Issue: opensearch-project/OpenSearch#9650
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.