Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value range for the search backpressure settings #8555

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Oct 17, 2024

Description

In 2.18.0, we add more strict validation for the search backpressure settings, we need to document the new change and the existing value range for those setting.

Issues Resolved

No issue.

Version

2.18.0

Frontend features

No change

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: gaobinlong <gbinlong@amazon.com>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @gaobinlong! Made some suggestions to reduce the cognitive overhead on the user.

@kolchfa-aws kolchfa-aws added v2.18.0 release-notes PR: Include this PR in the automated release notes labels Oct 17, 2024
Signed-off-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws
Copy link
Collaborator

@gaobinlong Let me know when the code PR is merged, and we can merge this one.

@kolchfa-aws kolchfa-aws added the 6 - Done but waiting to merge PR: The work is done and ready to merge label Oct 21, 2024
@gaobinlong
Copy link
Contributor Author

@gaobinlong Let me know when the code PR is merged, and we can merge this one.

Thanks @kolchfa-aws, the code PR has been merged yet.

@kolchfa-aws kolchfa-aws merged commit ddcb206 into opensearch-project:main Oct 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 - Done but waiting to merge PR: The work is done and ready to merge release-notes PR: Include this PR in the automated release notes v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants