-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap CreateIndexRequest mappings in _doc key as required #809
Wrap CreateIndexRequest mappings in _doc key as required #809
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
=========================================
Coverage 75.77% 75.77%
Complexity 834 834
=========================================
Files 88 88
Lines 4045 4046 +1
Branches 373 373
=========================================
+ Hits 3065 3066 +1
Misses 824 824
Partials 156 156 ☔ View full report in Codecov by Sentry. |
src/main/java/org/opensearch/flowframework/indices/FlowFrameworkIndicesHandler.java
Show resolved
Hide resolved
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Have we tested this fixes the issue btw |
I have manually tested the following 4 combinations:
The fix is precisely the specified in the javadoc. Following the javadoc should not cause an error. |
Signed-off-by: Daniel Widdis <widdis@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-809-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 834903f082e33eeea7360206745b5e2eaa160744
# Push it to GitHub
git push --set-upstream origin backport/backport-809-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.16
# Create a new branch
git switch --create backport/backport-809-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 834903f082e33eeea7360206745b5e2eaa160744
# Push it to GitHub
git push --set-upstream origin backport/backport-809-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.16 Then, create a pull request where the |
backports failed due to release notes change. Instead of manually backporting will wait for that to merge and then toggle the backport tags |
* Wrap CreateIndexRequest mappings in _doc key as required Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add changelog/release notes Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 834903f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Wrap CreateIndexRequest mappings in _doc key as required Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add changelog/release notes Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 834903f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ed (#814) Wrap CreateIndexRequest mappings in _doc key as required (#809) * Wrap CreateIndexRequest mappings in _doc key as required * Add changelog/release notes --------- (cherry picked from commit 834903f) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…red (#815) Wrap CreateIndexRequest mappings in _doc key as required (#809) * Wrap CreateIndexRequest mappings in _doc key as required * Add changelog/release notes --------- (cherry picked from commit 834903f) Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Adds the
_doc
key wrapper around index mapping as required byCreateIndexRequest
javadoc.Related Issues
Fixes #798
See also opensearch-project/OpenSearch#14984
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.