[Backport 2.x] Adds REST APIs for creating and provisioning a workflow (#63) #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject#63) * Inital implementation, set up rest/transport actions, registration, pending global context index, state index implementations Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments, seting params to snake case, removing redundant param default value, setting workflow request to read/write optional string Signed-off-by: Joshua Palis <jpalis@amazon.com> * Introducing getExecutorBuilders extension point to FlowFramworkPlugin, added FixedExecutorBuilder thread pool for provisioning tasks, set up async workflow execution, added TODOs for state/GC index handling Signed-off-by: Joshua Palis <jpalis@amazon.com> * updating unit tests for FlowFrameworkPluginTests, adding WorkflowRequestResponse unit tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding validate/toXContent tests for workflow request/responses Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding unit tests for create and provision rest actions Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments (Part 1). Moving common vlaues to CommonValue class Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments (Part 2), adding globalcontexthandler to create components, added updateTemplate(), indexExists() methods to handler and createIndex step respecitvely. Implemented CreateWorkflow/ProvisionWorkflow transport actions Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments (Part 3) Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing TODOs for RestAction constructors, adding basic unit tests for added methods in CreateIndexStep, GlobalContextHandler Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding CreateWorkflowTransportAction unit tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding intial failure test case for the ProvisionWorkflowTransportAction. Still need to add tests for success case Signed-off-by: Joshua Palis <jpalis@amazon.com> * Updating base URI namespace to workflow instead of workflows Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comment, updating invalid template config test, removing field via string replacement Signed-off-by: Joshua Palis <jpalis@amazon.com> * Add success test case for ProvisionWorkflowTransportAction Signed-off-by: Joshua Palis <jpalis@amazon.com> * Updating global context index mapping for template version and compatibility version fields from int to text Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing bugs, changed GC index mapping so that template/compatibility versions are of type text, added GC template document readers/writers, modified tests. Still need to add test cases for the new readers/writers Signed-off-by: Joshua Palis <jpalis@amazon.com> * Updating GlobalContextHandler.updateTemplate() to use toDocumentSource instead of toXContent() Signed-off-by: Joshua Palis <jpalis@amazon.com> * Replacing exceptions with FlowFrameworException Signed-off-by: Joshua Palis <jpalis@amazon.com> * Resolving javadoc warnings Signed-off-by: Joshua Palis <jpalis@amazon.com> * Cleaning up TODOs Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments, moving some common template parsing methods to a common TemplateUtil class Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> (cherry picked from commit 014475d)
joshpalis
requested review from
dbwiddis,
owaiskazi19,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Backport of #63