Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging for version increment automation #91

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Staging for version increment automation #91

merged 3 commits into from
Jul 29, 2022

Conversation

prudhvigodithi
Copy link
Contributor

@prudhvigodithi prudhvigodithi commented Jul 11, 2022

Description

This is the staging PR for to execute workflows that auto raise the version increment PR's
Example: prudhvigodithi/ml-commons#1

Issues Resolved

Part of: opensearch-project/opensearch-build#1375
From solution: opensearch-project/opensearch-build#1375 (comment)
Related issue: #86

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #91 (12ef4f4) into main (beac5dc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #91   +/-   ##
=========================================
  Coverage     86.50%   86.50%           
  Complexity      248      248           
=========================================
  Files            37       37           
  Lines           830      830           
  Branches         55       55           
=========================================
  Hits            718      718           
  Misses           87       87           
  Partials         25       25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beac5dc...12ef4f4. Read the comment docs.

Signed-off-by: pgodithi <pgodithi@amazon.com>
@prudhvigodithi
Copy link
Contributor Author

Renaming to task updateVersion following opensearch-project/opensearch-plugin-template-java#32.

@prudhvigodithi
Copy link
Contributor Author

Hey @VijayanB just checking back, if we are ok with PR, can we merge this?
Thank you

@VijayanB
Copy link
Member

@martin-gaievski Can you take a look at this PR? Thanks.

@martin-gaievski
Copy link
Member

martin-gaievski commented Jul 26, 2022

@prudhvigodithi did you test it when build.qualifier is set? At first glance it should work but it would be nice to have a confirmation.

@prudhvigodithi
Copy link
Contributor Author

Hey @martin-gaievski can you please elaborate, this task updateVersion will be called from the external workflow from the opensearch-build repo, all it will do is raise a version increment PR and update the required files.
@bbarani

@bbarani
Copy link
Member

bbarani commented Jul 26, 2022

@martin-gaievski Can you please provide your inputs?

@martin-gaievski
Copy link
Member

I think it should work, let me approve

@VijayanB
Copy link
Member

@prudhvigodithi Shall i merge this PR?

@prudhvigodithi
Copy link
Contributor Author

prudhvigodithi commented Jul 29, 2022

Hey @VijayanB yes please proceed to merge and backport to required release branches :)

@VijayanB VijayanB added the backport 2.x Backport PR to 2.x branch label Jul 29, 2022
@VijayanB VijayanB merged commit 38e663e into opensearch-project:main Jul 29, 2022
@VijayanB VijayanB added backport 2.x Backport PR to 2.x branch and removed backport 2.x Backport PR to 2.x branch labels Aug 1, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 1, 2022
* Version increment automation

Signed-off-by: pgodithi <pgodithi@amazon.com>
(cherry picked from commit 38e663e)
junqiu-lei pushed a commit that referenced this pull request Aug 2, 2022
* Version increment automation

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
(cherry picked from commit 38e663e)

Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
@junqiu-lei junqiu-lei added the backport 2.2 backport to 2.2 branch label Aug 2, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2022
* Version increment automation

Signed-off-by: pgodithi <pgodithi@amazon.com>
(cherry picked from commit 38e663e)
junqiu-lei pushed a commit that referenced this pull request Aug 2, 2022
* Version increment automation

Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
(cherry picked from commit 38e663e)

Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport PR to 2.x branch backport 2.2 backport to 2.2 branch v2.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants