Skip to content

Commit

Permalink
Be explicit when using empty objects in pipelineConfig
Browse files Browse the repository at this point in the history
Signed-off-by: Jan Høydahl <janhoy@users.noreply.github.com>
  • Loading branch information
janhoy committed Dec 4, 2024
1 parent 8d802b8 commit c770ad3
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
6 changes: 5 additions & 1 deletion charts/data-prepper/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
## [0.1.1]
### Fixed
- Make `simple-sample-pipeline` survive helm values merge by declaring empty yaml objects explicitly

## [0.1.0]
### Added
- Create initial version of data-prepper helm chart

2 changes: 1 addition & 1 deletion charts/data-prepper/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0
version: 0.1.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
8 changes: 4 additions & 4 deletions charts/data-prepper/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ pipelineConfig:
workers: 2 # the number of workers
delay: 5000 # in milliseconds, how long workers wait between read attempts
source:
random:
random: {}
buffer:
bounded_blocking:
buffer_size: 1024 # max number of records the buffer accepts
Expand All @@ -118,7 +118,7 @@ pipelineConfig:
- string_converter:
upper_case: true
sink:
- stdout:
- stdout: {}

## More Complex example
# otel-logs-pipeline:
Expand All @@ -128,7 +128,7 @@ pipelineConfig:
# otel_logs_source:
# ssl: false
# buffer:
# bounded_blocking:
# bounded_blocking: {}
# sink:
# - opensearch:
# hosts: ["https://opensearch-cluster-master:9200"]
Expand Down Expand Up @@ -178,7 +178,7 @@ pipelineConfig:
# buffer_size: 25600 # max number of records the buffer accepts
# batch_size: 400 # max number of records the buffer drains after each read
# processor:
# - otel_traces:
# - otel_traces: {}
# - otel_trace_group:
# hosts: [ "https://opensearch-cluster-master:9200" ]
# insecure: true
Expand Down

0 comments on commit c770ad3

Please sign in to comment.