store opensearch-dashboards configs in Secret (#426) #430
Conversation
rufdoSICKAG
requested review from
bbarani,
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
There was a problem hiding this comment.
Hi @rufdoSICKAG , thanks a lot for your contributions. Can you also update the README.md w.r.t this change.
|
Should it then also be possible to provide your own secret? e.g. when handling values through flux it would be desireable to not store these secret values in the configmap of the chart values. |
|
@rufdoSICKAG |
|
@TheAlgo sorry for the late response. I added the requested change to the README now. @ThoreKr @mustdiechik I think adding additional options should be handled in a separate PR after this change has been accepted. |
|
@TheAlgo @prudhvigodithi @peterzhuamazon Can we merge this PR? |
|
Hey @rufdoSICKAG, thanks for your contribution and patience, this change looks good to me, can you please fix the conflicts and we can merge this. |
opensearch_dashboards.yml contains values like opensearch.password or opensearch_security.openid.client_secret which should be stored in Secrets rather than ConfigMaps. Signed-off-by: Dominik Ruf <dominik.ruf@sick.de>
|
@prudhvigodithi I rebased my changes |
|
@prudhvigodithi can we merge this PR? |
|
@rufdoSICKAG can you please increment the chart version (as a patch release) and update the change-log ? Sample PR https://github.com/opensearch-project/helm-charts/pull/569/files |
|
@prudhvigodithi wouldn't it make more sense if who every manages the next release would do that?! |
opensearch_dashboards.yml contains values like
opensearch.password or opensearch_security.openid.client_secret which should be stored in Secrets rather than ConfigMaps.
Description
Because opensearch_dashboards.yml may contain secret values like opensearch.password or opensearch_security.openid.client_secret, it should be stored as Secret rather than a ConfigMap.
For comparison, the securityConfig in the opensearch chart is already stored as a Secret.
Issues Resolved
#426
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.