[Backport 1.x] Allow user-defined labels on pvcs #600
+21
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonstumpf
requested review from
TheAlgo,
DandyDeveloper,
peterzhuamazon,
prudhvigodithi and
gaiksaya
as code owners
Signed-off-by: Simon Stumpf <32813906+simonstumpf@users.noreply.github.com>
simonstumpf
force-pushed
the
backport-554
branch
from
0d40bea
to
cf6d1a6
Compare
|
Thanks @simonstumpf, backport of #591. |
prudhvigodithi
approved these changes
Sep 19, 2024
|
@simonstumpf can you please fix the failing CI's? |
|
Not sure why is the failure tho, pinging @simonstumpf Thanks. |
| @@ -14,6 +14,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Fixed | |||
| ### Security | |||
| --- | |||
| ## [1.32.0] | |||
| ### Added | |||
| - Allow user-defined labels on persistent volume claim | |||
There was a problem hiding this comment.
The original PR is a patch update, this might change to patch instead of minor update as well?
| @@ -715,7 +724,8 @@ config: | |||
| ### Fixed | |||
| ### Security | |||
|
|
|||
| [Unreleased]: https://github.com/opensearch-project/helm-charts/compare/opensearch-1.31.0...HEAD | |||
| [Unreleased]: https://github.com/opensearch-project/helm-charts/compare/opensearch-1.32.0...HEAD | |||
| [1.32.0]: https://github.com/opensearch-project/helm-charts/compare/opensearch-1.31.0...opensearch-1.32.0 | |||
| @@ -15,7 +15,7 @@ type: application | |||
| # This is the chart version. This version number should be incremented each time you make changes | |||
| # to the chart and its templates, including the app version. | |||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | |||
| version: 1.31.0 | |||
| version: 1.32.0 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for user-defined labels on PVCs.
Issues Resolved
Closes #554
Check List
For any changes to files within Helm chart directories:
CHANGELOG.mdupdated to reflect changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.