Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling github test workflows for all branches. #219

Conversation

AWSHurneyt
Copy link
Contributor

Signed-off-by: AWSHurneyt hurneyt@amazon.com

Description

Enabling github actions when submitting PRs directly to version branches.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…hes.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Copy link
Contributor Author

The cypress test workflow is failing because it needs to build against 2.2 if we're using OSD branch 2.x. We bumped our 2.x branch to 2.2 but didn't do it to main since we were planning on bumping it to 3.0 anyway. The bump to 3.0 is currently blocked on a bug being tracked in the OpenSearch repo as mentioned in opensearch-project/notifications#481

If the bump to 3.0 remains blocked, we'll get main on to 2.2 in the meantime or update the CI to properly build against OSD 2.1. The former would be the more consistent option since it would be strange to have our 2.x branch ahead of main in version.

@AWSHurneyt AWSHurneyt marked this pull request as ready for review August 5, 2022 01:03
@AWSHurneyt AWSHurneyt requested a review from a team August 5, 2022 01:03
@AWSHurneyt
Copy link
Contributor Author

The link checker action is failing due to this link in the README. It looks like other plugins are still referencing this webpage in their README files, but the link was broken when the opendistro repos were deprecated.

https://discuss.opendistrocommunity.dev/c/Use-this-category-for-all-questions-around-machine-learning-plugins

lezzago
lezzago previously approved these changes Aug 5, 2022
@@ -3,10 +3,14 @@ on:
pull_request:
branches:
- main
- 1.x
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct in assuming this means we don't want this to run on 1.3 and before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I based this configuration on the one used by the alerting dashboards workflows. We may want to reconfiguring both repos to check the 1.* branches considering the new branching strategy. For now, would it make sense to merge this as-is, and discuss enabling the checks for a future PR?

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt AWSHurneyt changed the title Enabling github actions when submitting PRs directly to version branches. Enabling github test workflows for all branches. Aug 11, 2022
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt
Copy link
Contributor Author

The link checker action is failing due to this link in the README. It looks like other plugins are still referencing this webpage in their README files, but the link was broken when the opendistro repos were deprecated.

https://discuss.opendistrocommunity.dev/c/Use-this-category-for-all-questions-around-machine-learning-plugins

Discussed this with @bowenlan-amzn , who recommended changing the link to this one https://forum.opensearch.org/c/plugins/index-management. I'll revise this PR.

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
@AWSHurneyt AWSHurneyt marked this pull request as draft August 11, 2022 20:09
@AWSHurneyt
Copy link
Contributor Author

@AWSHurneyt AWSHurneyt closed this Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants