-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling github test workflows for all branches. #219
Enabling github test workflows for all branches. #219
Conversation
…hes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
The cypress test workflow is failing because it needs to build against 2.2 if we're using OSD branch If the bump to |
The
|
@@ -3,10 +3,14 @@ on: | |||
pull_request: | |||
branches: | |||
- main | |||
- 1.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in assuming this means we don't want this to run on 1.3
and before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. I based this configuration on the one used by the alerting dashboards workflows. We may want to reconfiguring both repos to check the 1.*
branches considering the new branching strategy. For now, would it make sense to merge this as-is, and discuss enabling the checks for a future PR?
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Discussed this with @bowenlan-amzn , who recommended changing the link to this one https://forum.opensearch.org/c/plugins/index-management. I'll revise this PR. |
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: AWSHurneyt hurneyt@amazon.com
Description
Enabling github actions when submitting PRs directly to version branches.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.