Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version.yml GH workflow #233

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

prudhvigodithi
Copy link
Member

@prudhvigodithi prudhvigodithi commented Sep 5, 2022

Signed-off-by: prudhvigodithi pgodithi@amazon.com

Description

Remove version.yml GH workflow.
The version increment will be now part of workflow triggered from opensearch-build repo.
Sample version increment PR #230, triggered from central workflow which is part of the build repo.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
@prudhvigodithi prudhvigodithi requested a review from a team September 5, 2022 16:29
@prudhvigodithi prudhvigodithi changed the title Removed version.yml GH workflow Remove version.yml GH workflow Sep 5, 2022
@saratvemulapalli
Copy link
Member

Looks like the tests are failing:

Suite: Test class org.opensearch.jobscheduler.sampleextension.bwc.JobSchedulerBackwardsCompatibilityIT
  2> Set 05, 2022 8:34:08 QN org.opensearch.client.RestClient logResponse
  2> WARNING: request [PUT http://[::1]:40019/.scheduler_sample_extension/_doc/WCmQjoJGMj?refresh] returned 1 warnings: [299 OpenSearch-2.3.0-SNAPSHOT-5985955bd01cf4777c1fcc8ddb35beca0a79dcdf "index name [.scheduler_sample_extension] starts with a dot '.', in the next major version, index names starting with a dot are reserved for hidden indices and system indices"]
  2> REPRODUCE WITH: ./gradlew ':opensearch-job-scheduler-sample-extension:jobSchedulerBwcCluster#fullRestartClusterTask' --tests "org.opensearch.jobscheduler.sampleextension.bwc.JobSchedulerBackwardsCompatibilityIT.testBackwardsCompatibility" -Dtests.seed=20C2C0FB709ED9AD -Dtests.security.manager=true -Dtests.locale=mt -Dtests.timezone=Etc/GMT+8 -Druntime.java=17

Probably not relevant for this PR. But @prudhvigodithi @joshpalis could you guys create an issue and take a look. Probably main is broken.

@codecov-commenter
Copy link

Codecov Report

Merging #233 (637b9f1) into main (df154b8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #233   +/-   ##
=========================================
  Coverage     53.19%   53.19%           
  Complexity       65       65           
=========================================
  Files             8        8           
  Lines           438      438           
  Branches         50       50           
=========================================
  Hits            233      233           
  Misses          186      186           
  Partials         19       19           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@saratvemulapalli saratvemulapalli merged commit b9512f8 into opensearch-project:main Sep 7, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2022
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit b9512f8)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2022
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit b9512f8)
joshpalis pushed a commit that referenced this pull request Sep 7, 2022
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit b9512f8)
Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis pushed a commit that referenced this pull request Sep 7, 2022
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit b9512f8)
Signed-off-by: Joshua Palis <jpalis@amazon.com>
saratvemulapalli pushed a commit that referenced this pull request Sep 7, 2022
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit b9512f8)
Signed-off-by: Joshua Palis <jpalis@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
saratvemulapalli pushed a commit that referenced this pull request Sep 7, 2022
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit b9512f8)
Signed-off-by: Joshua Palis <jpalis@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit b9512f8)
Signed-off-by: Joshua Palis <jpalis@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
prudhvigodithi added a commit to prudhvigodithi/job-scheduler that referenced this pull request May 9, 2023
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
(cherry picked from commit b9512f8)
Signed-off-by: Joshua Palis <jpalis@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants