-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slf4j which is the dep of cronutils #256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenlan-amzn
force-pushed
the
main
branch
4 times, most recently
from
October 19, 2022 19:23
a537d15
to
a1d4276
Compare
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #256 +/- ##
============================================
- Coverage 53.19% 52.96% -0.23%
+ Complexity 65 64 -1
============================================
Files 8 8
Lines 438 438
Branches 50 50
============================================
- Hits 233 232 -1
Misses 186 186
- Partials 19 20 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshpalis
approved these changes
Oct 19, 2022
zengyan-amazon
approved these changes
Oct 24, 2022
saratvemulapalli
approved these changes
Oct 24, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 24, 2022
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 7dab8ea)
joshpalis
pushed a commit
that referenced
this pull request
Oct 24, 2022
wuychn
pushed a commit
to ochprince/job-scheduler
that referenced
this pull request
Mar 16, 2023
…nsearch-project#257) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 7dab8ea) Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
prudhvigodithi
pushed a commit
to prudhvigodithi/job-scheduler
that referenced
this pull request
May 9, 2023
…nsearch-project#257) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> (cherry picked from commit 7dab8ea) Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Job scheduler
- depend on -
cron-utils- depend on -
slf4jWhen we upgrade to OS 2.0, the dependency configuration
compile
is deprecated andimplementation
is used instead (code change), after this, the transitive dependency slf4j is not on the compileClassPath anymore so the relocation of slf4j is not working silently. This PR adds back the slf4j dependency so it can be relocated correctly again.To check whether the slf4j gets relocated:
jar tvf $file | grep -i "slf4j";
Issues Resolved
opensearch-project/index-management#519
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.