Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slf4j which is the dep of cronutils #256

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Oct 19, 2022

Description

Job scheduler - depend on - cron-utils - depend on - slf4j

When we upgrade to OS 2.0, the dependency configuration compile is deprecated and implementation is used instead (code change), after this, the transitive dependency slf4j is not on the compileClassPath anymore so the relocation of slf4j is not working silently. This PR adds back the slf4j dependency so it can be relocated correctly again.

To check whether the slf4j gets relocated:

  1. build job scheduler jar
  2. check if slf4j is relocated in the jar jar tvf $file | grep -i "slf4j";

Issues Resolved

opensearch-project/index-management#519

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #256 (9bf9477) into main (197eb97) will decrease coverage by 0.22%.
The diff coverage is n/a.

❗ Current head 9bf9477 differs from pull request most recent head c700d8f. Consider uploading reports for the commit c700d8f to get more accurate results

@@             Coverage Diff              @@
##               main     #256      +/-   ##
============================================
- Coverage     53.19%   52.96%   -0.23%     
+ Complexity       65       64       -1     
============================================
  Files             8        8              
  Lines           438      438              
  Branches         50       50              
============================================
- Hits            233      232       -1     
  Misses          186      186              
- Partials         19       20       +1     
Impacted Files Coverage Δ
...pensearch/jobscheduler/scheduler/JobScheduler.java 72.94% <0.00%> (-1.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review October 19, 2022 20:03
@bowenlan-amzn bowenlan-amzn requested a review from a team October 19, 2022 20:03
@saratvemulapalli saratvemulapalli merged commit 7dab8ea into opensearch-project:main Oct 24, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2022
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
(cherry picked from commit 7dab8ea)
joshpalis pushed a commit that referenced this pull request Oct 24, 2022
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
(cherry picked from commit 7dab8ea)

Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
wuychn pushed a commit to ochprince/job-scheduler that referenced this pull request Mar 16, 2023
…nsearch-project#257)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
(cherry picked from commit 7dab8ea)

Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
prudhvigodithi pushed a commit to prudhvigodithi/job-scheduler that referenced this pull request May 9, 2023
…nsearch-project#257)

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>

Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com>
(cherry picked from commit 7dab8ea)

Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants