Publishing jars to org.opensearch.opensearch-job-scheduler #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <jpalis@amazon.com>
owaiskazi19
approved these changes
Feb 24, 2023
|
|
We are not publishing javadoc and sources jar https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/opensearch-job-scheduler/3.0.0.0-SNAPSHOT/ |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #336 +/- ##
=========================================
Coverage 30.23% 30.23%
Complexity 97 97
=========================================
Files 22 22
Lines 1128 1128
Branches 107 107
=========================================
Hits 341 341
Misses 766 766
Partials 21 21 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hey Its ok to publish the javadoc and source jar since the source code is already open sourced, thats the default behaviour with publish as well, I see example common-utils already doing it, so the PR LGTM! |
prudhvigodithi
approved these changes
Feb 24, 2023
dbwiddis
approved these changes
Feb 24, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 24, 2023
(cherry picked from commit 0711f3b)
joshpalis
added a commit
that referenced
this pull request
Feb 27, 2023
(cherry picked from commit 0711f3b) Signed-off-by: Joshua Palis <jpalis@amazon.com>
dbwiddis
pushed a commit
that referenced
this pull request
Feb 27, 2023
prudhvigodithi
pushed a commit
to prudhvigodithi/job-scheduler
that referenced
this pull request
May 9, 2023
…h-project#336) (opensearch-project#337) (cherry picked from commit 0711f3b) Signed-off-by: Joshua Palis <jpalis@amazon.com> Co-authored-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates org.opensearch.opensearch-job-scheduler with maven jars
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.