Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.x] Adding auto delete workflow for backport branches #290

Closed
wants to merge 1 commit into from
Closed

[Backport 1.x] Adding auto delete workflow for backport branches #290

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport cb1a7d8 from #289

@VachaShah @github-actions
Adding auto delete workflow for backport branches (#289)
a48170c 
Signed-off-by: Vacha Shah <vachshah@amazon.com>
(cherry picked from commit cb1a7d8)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team February 11, 2022 21:05
@VachaShah
Copy link
Contributor

Not sure why the DCO check is failing with error:

a48170ca23e18235ddf9326d3177c0eb11b8135c    Expected "Vacha <vachshah@amazon.com>", but got "Vacha Shah <vachshah@amazon.com>".

@VachaShah
Copy link
Contributor

Not sure why the DCO check is failing with error:

a48170ca23e18235ddf9326d3177c0eb11b8135c    Expected "Vacha <vachshah@amazon.com>", but got "Vacha Shah <vachshah@amazon.com>".

Found the reason. My profile had just Vacha as the name so the action picked that up. I fixed it to be the same as my signature Vacha Shah. Future PRs should not have this issue.

@VachaShah VachaShah requested a review from jmazanec15 February 15, 2022 23:22
@jmazanec15
Copy link
Member

Hi @VachaShah, I think before we check in, DCO will need to be fixed. Im not sure how this can be done without force pushing to this branch.

@VachaShah VachaShah mentioned this pull request Feb 16, 2022
Merged
1 task
@VachaShah
Copy link
Contributor

Hi @VachaShah, I think before we check in, DCO will need to be fixed. Im not sure how this can be done without force pushing to this branch.

Hi @jmazanec15, yeah I am not able to force push to this branch. I will close this PR and open a new one from my fork.

@VachaShah
Copy link
Contributor

Closing in favor of #291.

@VachaShah VachaShah closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-gaievski martin-gaievski martin-gaievski approved these changes

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VachaShah @jmazanec15 @martin-gaievski