-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Build.sh Related Changes in k-NN #595
Merged
peterzhuamazon
merged 1 commit into
opensearch-project:2.x
from
naveentatikonda:add_windows_support_2.x_peterzhuamazon
Oct 27, 2022
Merged
Add Windows Build.sh Related Changes in k-NN #595
peterzhuamazon
merged 1 commit into
opensearch-project:2.x
from
naveentatikonda:add_windows_support_2.x_peterzhuamazon
Oct 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzhuamazon
added
Enhancements
Increases software capabilities beyond original client specifications
enhancement
windows
labels
Oct 26, 2022
Closed
2 tasks
1 task
Codecov Report
@@ Coverage Diff @@
## 2.x #595 +/- ##
============================================
+ Coverage 83.63% 84.58% +0.94%
- Complexity 1028 1054 +26
============================================
Files 148 149 +1
Lines 4235 4301 +66
Branches 373 382 +9
============================================
+ Hits 3542 3638 +96
+ Misses 517 486 -31
- Partials 176 177 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peterzhuamazon
force-pushed
the
add_windows_support_2.x_peterzhuamazon
branch
from
October 27, 2022 00:28
26242a6
to
5247114
Compare
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
force-pushed
the
add_windows_support_2.x_peterzhuamazon
branch
from
October 27, 2022 00:32
349b4fb
to
65b613b
Compare
jmazanec15
approved these changes
Oct 27, 2022
naveentatikonda
approved these changes
Oct 27, 2022
We will hold on the merge of this until tomorrow final check on Jenkins. |
heemin32
added
2.4.0
v2.4.0
'Issues and PRs related to version v2.4.0'
and removed
2.4.0
labels
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Enhancements
Increases software capabilities beyond original client specifications
v2.4.0
'Issues and PRs related to version v2.4.0'
windows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Windows Build.sh Related Changes in k-NN.
Include new changes in windows and streamline linux builds.
This is based on @naveentatikonda 2.x windows support branch.
Needs to be merged only when #583 is merged.
We also need the ci repo PR opensearch-project/opensearch-ci#212 to be merged to support
$MINGW_BIN
.Thanks
Issues Resolved
opensearch-project/opensearch-build#2306
#157
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.