Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Build.sh Related Changes in k-NN #595

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Oct 26, 2022

Description

Add Windows Build.sh Related Changes in k-NN.
Include new changes in windows and streamline linux builds.

This is based on @naveentatikonda 2.x windows support branch.
Needs to be merged only when #583 is merged.
We also need the ci repo PR opensearch-project/opensearch-ci#212 to be merged to support $MINGW_BIN.

Thanks

Issues Resolved

opensearch-project/opensearch-build#2306
#157

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added Enhancements Increases software capabilities beyond original client specifications enhancement windows labels Oct 26, 2022
@peterzhuamazon peterzhuamazon requested a review from a team October 26, 2022 02:47
@peterzhuamazon peterzhuamazon self-assigned this Oct 26, 2022
@peterzhuamazon peterzhuamazon mentioned this pull request Oct 26, 2022
3 tasks
@peterzhuamazon peterzhuamazon linked an issue Oct 26, 2022 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #595 (d318537) into 2.x (9d2bc9d) will increase coverage by 0.94%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #595      +/-   ##
============================================
+ Coverage     83.63%   84.58%   +0.94%     
- Complexity     1028     1054      +26     
============================================
  Files           148      149       +1     
  Lines          4235     4301      +66     
  Branches        373      382       +9     
============================================
+ Hits           3542     3638      +96     
+ Misses          517      486      -31     
- Partials        176      177       +1     
Impacted Files Coverage Δ
...main/java/org/opensearch/knn/plugin/KNNPlugin.java 100.00% <0.00%> (ø)
...va/org/opensearch/knn/plugin/stats/KNNCounter.java 100.00% <0.00%> (ø)
...rg/opensearch/knn/index/codec/KNNCodecService.java 100.00% <0.00%> (ø)
...earch/knn/index/codec/KNN910Codec/KNN910Codec.java 100.00% <0.00%> (ø)
...earch/knn/index/codec/KNN940Codec/KNN940Codec.java 100.00% <0.00%> (ø)
...g/opensearch/knn/index/codec/KNNFormatFactory.java
...rg/opensearch/knn/index/codec/KNNCodecFactory.java
.../knn/index/codec/BasePerFieldKnnVectorsFormat.java 58.33% <0.00%> (ø)
...rg/opensearch/knn/index/codec/KNNCodecVersion.java 80.76% <0.00%> (ø)
.../java/org/opensearch/knn/index/KNNClusterUtil.java 100.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon peterzhuamazon force-pushed the add_windows_support_2.x_peterzhuamazon branch from 26242a6 to 5247114 Compare October 27, 2022 00:28
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon force-pushed the add_windows_support_2.x_peterzhuamazon branch from 349b4fb to 65b613b Compare October 27, 2022 00:32
@peterzhuamazon
Copy link
Member Author

We will hold on the merge of this until tomorrow final check on Jenkins.
Thanks.

@peterzhuamazon peterzhuamazon merged commit 0eece60 into opensearch-project:2.x Oct 27, 2022
@peterzhuamazon peterzhuamazon deleted the add_windows_support_2.x_peterzhuamazon branch October 27, 2022 20:56
@naveentatikonda naveentatikonda restored the add_windows_support_2.x_peterzhuamazon branch October 28, 2022 21:10
@heemin32 heemin32 added 2.4.0 v2.4.0 'Issues and PRs related to version v2.4.0' and removed 2.4.0 labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements Increases software capabilities beyond original client specifications v2.4.0 'Issues and PRs related to version v2.4.0' windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Windows Support
5 participants