Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Build.sh Related Changes #602

Conversation

naveentatikonda
Copy link
Member

Description

Add Windows Build.sh Related Changes in k-NN.
Include new changes in windows and streamline linux builds.
Cherry-picked from 65b613b

Issues Resolved

#157

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveentatikonda naveentatikonda added Enhancements Increases software capabilities beyond original client specifications windows 2.4.0 labels Oct 28, 2022
@naveentatikonda naveentatikonda requested a review from a team October 28, 2022 21:41
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@naveentatikonda naveentatikonda force-pushed the windows_build_script_changes branch from f2d471a to 195d26d Compare October 28, 2022 21:43
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Merging #602 (195d26d) into main (fddfe19) will increase coverage by 0.25%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #602      +/-   ##
============================================
+ Coverage     84.54%   84.80%   +0.25%     
- Complexity     1050     1055       +5     
============================================
  Files           149      149              
  Lines          4291     4291              
  Branches        379      379              
============================================
+ Hits           3628     3639      +11     
+ Misses          486      477       -9     
+ Partials        177      175       -2     
Impacted Files Coverage Δ
...ain/java/org/opensearch/knn/index/KNNSettings.java 83.08% <0.00%> (+2.20%) ⬆️
...va/org/opensearch/knn/index/KNNCircuitBreaker.java 80.00% <0.00%> (+20.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@naveentatikonda naveentatikonda merged commit 120c4ce into opensearch-project:main Oct 31, 2022
@heemin32 heemin32 added v2.4.0 'Issues and PRs related to version v2.4.0' and removed 2.4.0 labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancements Increases software capabilities beyond original client specifications v2.4.0 'Issues and PRs related to version v2.4.0' windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants