Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix to fromXContent and toXContent in ModelGraveyard #618

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Add fix to fromXContent and toXContent in ModelGraveyard #618

merged 2 commits into from
Nov 10, 2022

Conversation

naveentatikonda
Copy link
Member

@naveentatikonda naveentatikonda commented Nov 9, 2022 •
edited
Loading

Signed-off-by: Naveen Tatikonda navtat@amazon.com

Description

Add fix to fromXContent and toXContent in ModelGraveyard, where before adding this fix it will fail to bootup after a node drop or if cluster is killed.

Issues Resolved

#619

Check List

  • New functionality includes testing.
  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveentatikonda
Add fix to fromXContent and toXContent in ModelGraveyard
944dca4 
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@naveentatikonda naveentatikonda requested a review from a team November 9, 2022 20:18
@naveentatikonda naveentatikonda self-assigned this Nov 9, 2022
@naveentatikonda naveentatikonda added Bug Fixes Changes to a system or product designed to handle a programming bug/glitch v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 9, 2022
@jmazanec15
Copy link
Member

Also, we are going to need to backport this to 2.3 as well as port forward to 2.x and main

@heemin32
Copy link
Collaborator

heemin32 commented Nov 9, 2022

As this goes to 2.4, please update release notes as well.

@naveentatikonda
Copy link
Member Author

Also, we are going to need to backport this to 2.3 as well as port forward to 2.x and main

Will backport this PR to main, 2.x and 2.3 branches

@naveentatikonda
Copy link
Member Author

As this goes to 2.4, please update release notes as well.

Working on it now

@naveentatikonda naveentatikonda force-pushed the add_fix_to_XContent_ModelGraveyard branch from c7d1a19 to 5a52289 Compare November 9, 2022 20:42
@naveentatikonda naveentatikonda mentioned this pull request Nov 9, 2022
Merged
1 task
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022 •
edited
Loading

Codecov Report

Merging #618 (219e89f) into 2.4 (0b7c923) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##                2.4     #618      +/-   ##
============================================
- Coverage     84.51%   84.49%   -0.02%     
- Complexity     1054     1058       +4     
============================================
  Files           149      149              
  Lines          4301     4316      +15     
  Branches        382      388       +6     
============================================
+ Hits           3635     3647      +12     
  Misses          489      489              
- Partials        177      180       +3
Impacted Files Coverage Δ
...ava/org/opensearch/knn/indices/ModelGraveyard.java 90.27% <75.00%> (-2.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon peterzhuamazon mentioned this pull request Nov 9, 2022
Closed
52 tasks
martin-gaievski
martin-gaievski previously approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice finding, thanks Naveen

@naveentatikonda naveentatikonda force-pushed the add_fix_to_XContent_ModelGraveyard branch from 5a52289 to 219e89f Compare November 10, 2022 19:00
@naveentatikonda
Address Review Comments
3da45c2 
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
@naveentatikonda naveentatikonda force-pushed the add_fix_to_XContent_ModelGraveyard branch from 219e89f to 3da45c2 Compare November 10, 2022 21:02
@naveentatikonda naveentatikonda merged commit f92651b into opensearch-project:2.4 Nov 10, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 10, 2022
@naveentatikonda @github-actions
Add fix to fromXContent and toXContent in ModelGraveyard (#618)
da874b9 
* Add fix to fromXContent and toXContent in ModelGraveyard

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit f92651b)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 10, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 10, 2022
@naveentatikonda @github-actions
Add fix to fromXContent and toXContent in ModelGraveyard (#618)
f541619 
* Add fix to fromXContent and toXContent in ModelGraveyard

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit f92651b)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 10, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 10, 2022
@naveentatikonda @github-actions
Add fix to fromXContent and toXContent in ModelGraveyard (#618)
829f95f 
* Add fix to fromXContent and toXContent in ModelGraveyard

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit f92651b)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 10, 2022
Merged
naveentatikonda added a commit that referenced this pull request Nov 10, 2022
@opensearch-trigger-bot @naveentatikonda
Add fix to fromXContent and toXContent in ModelGraveyard (#618) (#623)
9d4cf3f 
* Add fix to fromXContent and toXContent in ModelGraveyard

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit f92651b)

Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda added a commit that referenced this pull request Nov 10, 2022
@opensearch-trigger-bot @naveentatikonda
Add fix to fromXContent and toXContent in ModelGraveyard (#618) (#625)
888e696 
* Add fix to fromXContent and toXContent in ModelGraveyard

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit f92651b)

Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda added a commit that referenced this pull request Dec 14, 2022
@naveentatikonda
Add fix to fromXContent and toXContent in ModelGraveyard (#618)
825fb2a 
* Add fix to fromXContent and toXContent in ModelGraveyard

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit f92651b)
naveentatikonda added a commit that referenced this pull request Dec 14, 2022
@opensearch-trigger-bot @naveentatikonda
Add fix to fromXContent and toXContent in ModelGraveyard (#618) (#624)
9e79efc 
* Add fix to fromXContent and toXContent in ModelGraveyard

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit f92651b)

Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 14, 2022
@naveentatikonda @github-actions
Add fix to fromXContent and toXContent in ModelGraveyard (#618)
012a68d 
* Add fix to fromXContent and toXContent in ModelGraveyard

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit f92651b)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Dec 14, 2022
Merged
naveentatikonda added a commit that referenced this pull request Dec 14, 2022
@opensearch-trigger-bot @naveentatikonda
Add fix to fromXContent and toXContent in ModelGraveyard (#618) (#680)
4be0ad6 
* Add fix to fromXContent and toXContent in ModelGraveyard

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

* Address Review Comments

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
(cherry picked from commit f92651b)

Co-authored-by: Naveen Tatikonda <navtat@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-gaievski martin-gaievski martin-gaievski approved these changes

@jmazanec15 jmazanec15 jmazanec15 approved these changes

Assignees

@naveentatikonda naveentatikonda

Labels
backport main backport 2.x backport 2.2 backport 2.3 Backport to 2.3 branch Bug Fixes Changes to a system or product designed to handle a programming bug/glitch v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@naveentatikonda @jmazanec15 @heemin32 @codecov-commenter @martin-gaievski