Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Support to BWC Tests #726

Conversation

naveentatikonda
Copy link
Member

Signed-off-by: Naveen navtat@amazon.com

Description

Add Windows Support to Backwards Compatibility Tests

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@naveentatikonda naveentatikonda requested a review from a team January 12, 2023 19:49
@naveentatikonda naveentatikonda added windows backport 2.x backport 2.4 backport to 2.4 branch Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Jan 12, 2023
@naveentatikonda naveentatikonda self-assigned this Jan 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Merging #726 (66f1594) into main (8a2aa04) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #726   +/-   ##
=========================================
  Coverage     84.43%   84.43%           
  Complexity     1072     1072           
=========================================
  Files           152      152           
  Lines          4356     4356           
  Branches        389      389           
=========================================
  Hits           3678     3678           
  Misses          498      498           
  Partials        180      180           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@naveentatikonda naveentatikonda force-pushed the add_bwc_suport_windows branch 4 times, most recently from 7fb81a5 to 9479c6c Compare January 12, 2023 22:16
qa/build.gradle Outdated
@@ -1,3 +1,6 @@
import org.apache.tools.ant.taskdefs.condition.Os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License header should be at the top.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

Signed-off-by: Naveen <navtat@amazon.com>
@naveentatikonda naveentatikonda merged commit a79a58b into opensearch-project:main Jan 18, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-726-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a79a58b936e95e595f9b92d67a35e2d712adc69d
# Push it to GitHub
git push --set-upstream origin backport/backport-726-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-726-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-726-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a79a58b936e95e595f9b92d67a35e2d712adc69d
# Push it to GitHub
git push --set-upstream origin backport/backport-726-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport/backport-726-to-2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.4 backport to 2.4 branch Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants