Replace KnnQueryVector by KnnFloatVectorQuery for Lucene knn #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
added
Maintenance
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #767 +/- ##
============================================
- Coverage 85.40% 85.14% -0.26%
+ Complexity 1084 1079 -5
============================================
Files 151 151
Lines 4370 4370
Branches 390 390
============================================
- Hits 3732 3721 -11
- Misses 463 472 +9
- Partials 175 177 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
naveentatikonda
approved these changes
Feb 17, 2023
VijayanB
approved these changes
Feb 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 71d7232)
martin-gaievski
added a commit
that referenced
this pull request
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KnnQueryVector has been marked as deprecated in Lucene 9.5 and new implementation created instead. We need to follow Lucene path as we do return their implementation directly.
Issues Resolved
#766
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.