Make ci compatible with os2.x #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't run the parent_spec for opensearch >= 2.x Update index_spec.rb and compressed_indexing_spec.rb to not expect the _type field in the doc for Opensearch >= 2.0.0 Signed-off-by: Deep Datta <deedatta@amazon.com>
Signed-off-by: Deep Datta <deedatta@amazon.com>
dlvenable
approved these changes
Aug 8, 2022
…ent the version fetch from failing. For some logstash version e.g. 7.17.1, 8.3.2 the images are missing python leading to the following comand in scripts/logstash-run.sh to fail echo $(curl -s $SERVICE_URL | python -c "import sys, json; print(json.load(sys.stdin)['version']['number'])") That is causing some integration test to fail which depends on the OpenSearch version number. Signed-off-by: Deep Datta <deedatta@amazon.com>
dlvenable
reviewed
Aug 9, 2022
Signed-off-by: Deep Datta <deedatta@amazon.com>
Signed-off-by: Deep Datta <deedatta@amazon.com>
sshivanii
reviewed
Aug 10, 2022
| @@ -34,7 +34,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| logstash: [ "7.16.3", "7.17.1", "8.3.2" ] | |||
| opensearch: [ "1.2.1" ] | |||
| opensearch: [ "1.3.4", "2.1.0" ] | |||
There was a problem hiding this comment.
Does this mean we don't want the 1.2.1 version at all?
There was a problem hiding this comment.
Other clients tests against all released version.
There was a problem hiding this comment.
yes, we want to run the tests only on the latest released versions of 1.x and 2.x
sshivanii
approved these changes
Aug 10, 2022
This was
linked to
issues
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the integration tests to work with OpenSearch 2.x and add OpenSearch 2.1.0 in the CI test matrix.
Also update the OpenSearch 1.x version in CI from 1.2.1 to 1.3.4
Issues Resolved
#148
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.