Update references #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change references to opensearch in comments, documentation and other places. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
vamshin
reviewed
Jun 25, 2021
| @@ -168,8 +168,7 @@ def sniff! | |||
| update_urls(check_sniff) | |||
| end | |||
|
|
|||
| ES1_SNIFF_RE_URL = /\[([^\/]*)?\/?([^:]*):([0-9]+)\]/ | |||
| ES2_AND_ABOVE_SNIFF_RE_URL = /([^\/]*)?\/?([^:]*):([0-9]+)/ | |||
| SNIFF_RE_URL = /([^\/]*)?\/?([^:]*):([0-9]+)/ | |||
There was a problem hiding this comment.
Is it better to use ES2_AND_ABOVE_SNIFF_RE_URL?
There was a problem hiding this comment.
never mind. You are already using ES2_AND_ABOVE_SNIFF_RE_URL.
jmazanec15
approved these changes
Jun 25, 2021
VijayanB
added
the
Refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Description
Change references to opensearch in comments, documentation and other
places.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.