Add workflow to publish linux x86_64 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamshin
reviewed
Jun 28, 2021
.github/workflows/cd.yml
Outdated
| run: | | ||
| mkdir -p prepare-install; | ||
| mv logstash-output-opensearch-*.gem prepare-install/logstash-output-opensearch.gem; | ||
| wget --no-verbose https://artifacts.elastic.co/downloads/logstash/logstash-oss-7.13.2-linux-x86_64.tar.gz -P prepare-install/; |
There was a problem hiding this comment.
can logstash oss version be made dynamic to download?
jmazanec15
reviewed
Jun 28, 2021
.github/workflows/cd.yml
Outdated
| @@ -0,0 +1,40 @@ | |||
| name: Publish logstash-oss-with-opensearch-plugin | |||
There was a problem hiding this comment.
Nit: Could cd.yml be renamed to CD.yml? It seems that is the convention for plugins.
.github/workflows/cd.yml
Outdated
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: "logstash-oss-with-opensearch-plugin-7.13.2-linux-x86_64.tar.gz" | ||
| path: prepare-install/logstash-oss-with-opensearch-plugin-7.13.2-linux-x86_64.tar.gz |
There was a problem hiding this comment.
For discussion, should the artifact use x64 as this is what we use for OpenSearch artifacts: https://opensearch.org/downloads.html or do we want to keep consistent with logstash convention of x86_64
There was a problem hiding this comment.
I renamed to our naming convention
VijayanB
force-pushed
the
publish
branch
2 times, most recently
from
678f383 to
a57dd5a
Compare
Download logstash, build plugin, install plugin and publish logstash-oss-7.13.2-linux-x64.tar.gz Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
jmazanec15
approved these changes
Jul 1, 2021
VijayanB
added
the
Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Description
Download logstash, build plugin, install plugin and
publish logstash-oss-7.13.2-linux-x86_64.tar.gz
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.