Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the gem building errors before docker creation #43

Merged
merged 5 commits into from
Jul 29, 2021

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jul 29, 2021

Description

Resolve the gem building errors before docker creation

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has documentation added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon requested a review from VijayanB July 29, 2021 20:10
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon changed the title Tweak and improve the docker script comments Resolve the gem building errors before docker creation Jul 29, 2021
@peterzhuamazon peterzhuamazon merged commit 2c8437c into main Jul 29, 2021
@peterzhuamazon peterzhuamazon deleted the opensearch-logstash-multiarch branch July 29, 2021 22:33
VijayanB pushed a commit to VijayanB/logstash-output-opensearch that referenced this pull request Aug 5, 2021
…oject#43)

* Add new docker building scripts for logstash

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Move build related vars to the top

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Tweak and improve the docker script comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Resolve gem building incorrectly due to move of spec files

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@VijayanB VijayanB mentioned this pull request Aug 5, 2021
5 tasks
VijayanB pushed a commit to VijayanB/logstash-output-opensearch that referenced this pull request Aug 5, 2021
…oject#43)

* Add new docker building scripts for logstash

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Move build related vars to the top

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Tweak and improve the docker script comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Resolve gem building incorrectly due to move of spec files

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
This was referenced Aug 5, 2021
VijayanB pushed a commit to VijayanB/logstash-output-opensearch that referenced this pull request Aug 5, 2021
…oject#43)

* Add new docker building scripts for logstash

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Move build related vars to the top

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Tweak and improve the docker script comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Resolve gem building incorrectly due to move of spec files

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@VijayanB VijayanB mentioned this pull request Aug 5, 2021
5 tasks
VijayanB pushed a commit that referenced this pull request Aug 6, 2021
* Add new docker building scripts for logstash

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Move build related vars to the top

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Tweak and improve the docker script comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Resolve gem building incorrectly due to move of spec files

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@VijayanB VijayanB added the Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Aug 6, 2021
VijayanB pushed a commit that referenced this pull request Aug 6, 2021
* Add new docker building scripts for logstash

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Move build related vars to the top

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Tweak and improve the docker script comments

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Resolve gem building incorrectly due to move of spec files

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants