Update docker build script #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
force-pushed
the
update-docker
branch
2 times, most recently
from
f5c7d9d to
c9cf196
Compare
VijayanB
added
the
Infrastructure
VijayanB
force-pushed
the
update-docker
branch
from
c9cf196 to
ca2b3a9
Compare
| echo "" | ||
| echo "Required arguments:" | ||
| echo -e "-v VERSION \tSpecify the Logstash OSS version that you are building, e.g. '7.13.2'. This will be used to label the Docker image." | ||
| echo -e "-i INSTALLATION TYPE\tSpecify the installation type t, e.g. local will build and install, while download, will download latest ruby gems and install." |
jmazanec15
reviewed
Oct 26, 2021
VijayanB
force-pushed
the
update-docker
branch
from
ca2b3a9 to
c3b8b75
Compare
Parameterize docker build script with logstash version and installation type. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
force-pushed
the
update-docker
branch
from
c3b8b75 to
cbf755d
Compare
jmazanec15
approved these changes
Oct 26, 2021
peterzhuamazon
approved these changes
Oct 27, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Description
Parameterize docker build script with logstash version and
installation type.
Issues Resolved
#86
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.