Add version decoupling meta for MDS #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
ruanyl
reviewed
Jul 9, 2024
Comment on lines
+16
to
+17
| "supportedOSDataSourceVersions": ">=2.9.0", | ||
| "requiredOSDataSourcePlugins": ["opensearch-ml"] |
There was a problem hiding this comment.
Are these key names defined by each plugins? Is it standardized?
There was a problem hiding this comment.
Yeah. These key names were been introduced in these two PRs:
opensearch-project/OpenSearch-Dashboards#7146
opensearch-project/OpenSearch-Dashboards#7100
They are optional properties, all plugins should using the same key names.
raintygao
approved these changes
Jul 10, 2024
ruanyl
approved these changes
Jul 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
* Add version decoupling meta for MDS Signed-off-by: Lin Wang <wonglam@amazon.com> * Filter out not compatible data sources Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix in operator not work Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit ab60678)
wanglam
added a commit
that referenced
this pull request
Jul 11, 2024
* Add version decoupling meta for MDS Signed-off-by: Lin Wang <wonglam@amazon.com> * Filter out not compatible data sources Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix in operator not work Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit ab60678) Co-authored-by: Lin Wang <wonglam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add version decoupling meta data for MDS, a part of opensearch-project/OpenSearch-Dashboards#5877
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.