Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ml-commons plugin 3.0.0 baseline JDK version to JDK-21 #2583

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Jun 20, 2024

Description

Set ml-commons plugin 3.0.0 baseline JDK version to JDK-21

Issues Resolved

Closes #2503

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@@ -7,9 +7,9 @@ plugins {
id 'java'
id "io.freefair.lombok"
id 'jacoco'
id 'com.github.johnrengelman.shadow'
id 'io.github.goooler.shadow' version "8.1.7"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See please GradleUp/shadow#908


configurations {
classpath {
resolutionStrategy {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhrubo-os
Copy link
Collaborator

 > Task :opensearch-ml-common:compileJava FAILED

> Task :opensearch-ml-client:generateTestEffectiveLombokConfig
FAILURE: Build failed with an exception.
> Task :opensearch-ml-client:generateEffectiveLombokConfig
> Task :opensearch-ml-memory:generateEffectiveLombokConfig


Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

* What went wrong:
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
Execution failed for task ':opensearch-ml-common:compileJava'.

> error: invalid source release: 21
For more on this, please refer to https://docs.gradle.org/8.8/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

@reta
Copy link
Contributor Author

reta commented Jun 20, 2024

@dhrubo-os thanks for looking, we need #2584 first

@reta reta had a problem deploying to ml-commons-cicd-env June 21, 2024 20:12 — with GitHub Actions Failure
@reta reta had a problem deploying to ml-commons-cicd-env June 21, 2024 20:12 — with GitHub Actions Error
@reta reta had a problem deploying to ml-commons-cicd-env June 21, 2024 20:12 — with GitHub Actions Error
@reta reta had a problem deploying to ml-commons-cicd-env June 21, 2024 20:12 — with GitHub Actions Error
@reta reta had a problem deploying to ml-commons-cicd-env June 21, 2024 20:12 — with GitHub Actions Failure
@reta reta had a problem deploying to ml-commons-cicd-env June 21, 2024 20:12 — with GitHub Actions Error
@reta
Copy link
Contributor Author

reta commented Jun 27, 2024

@dhrubo-os could you please recheck this one? thank you

@reta reta temporarily deployed to ml-commons-cicd-env June 27, 2024 15:30 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env June 27, 2024 15:31 — with GitHub Actions Inactive
@reta reta had a problem deploying to ml-commons-cicd-env June 27, 2024 16:30 — with GitHub Actions Failure
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta temporarily deployed to ml-commons-cicd-env June 27, 2024 16:55 — with GitHub Actions Inactive
@reta reta temporarily deployed to ml-commons-cicd-env June 27, 2024 16:56 — with GitHub Actions Inactive
@reta reta had a problem deploying to ml-commons-cicd-env June 27, 2024 17:53 — with GitHub Actions Failure
@@ -101,6 +101,11 @@ jobs:
role-to-assume: ${{ secrets.ML_ROLE }}
aws-region: us-west-2

- name: Setup Java ${{ matrix.java }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should fix the compilation problem (but sadly GA does not pick the workflow from the pull request)

@reta
Copy link
Contributor Author

reta commented Jul 4, 2024

@dhrubo-os anything holding off the merge? (the GA worflow should be fixed by this change) thank you!

@dhrubo-os dhrubo-os merged commit 20255e3 into opensearch-project:main Jul 8, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Set ml-commons plugin 3.0.0 baseline JDK version to JDK-21
3 participants