-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create model/task index with correct mapping #284
Conversation
Signed-off-by: Yaliang Wu <ylwu@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #284 +/- ##
============================================
- Coverage 92.16% 91.98% -0.19%
+ Complexity 360 359 -1
============================================
Files 51 51
Lines 1111 1111
Branches 51 51
============================================
- Hits 1024 1022 -2
- Misses 69 70 +1
- Partials 18 19 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-284-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0bae1348c80463ea40f193d0db8f8ccfd2467dd0
# Push it to GitHub
git push --set-upstream origin backport/backport-284-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-284-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0bae1348c80463ea40f193d0db8f8ccfd2467dd0
# Push it to GitHub
git push --set-upstream origin backport/backport-284-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3 Then, create a pull request where the |
Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit 0bae134)
Signed-off-by: Yaliang Wu <ylwu@amazon.com> (cherry picked from commit 0bae134)
Signed-off-by: Yaliang Wu ylwu@amazon.com
Description
We found security test
testReadOnlyUser_CanSearchModels
failed. Debug locally and found ML model index mapping is wrong: filedalgorithm
was set astext
typeSo when search with this query, will return empty result.
This PR fix this bug by setting mapping in create index request. Will backport this to
2.x
and2.0
.Bug introduced in this PR #257
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.