Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group id for ml-commons dependency #32

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

jmazanec15
Copy link
Member

Description

Appends plugin to group ID for ml-commons dependency. Recently, ml-commons added this for their publishing zip task.

To confirm this is correct, we see that:
https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-ml-plugin/
is more up to date than
https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/opensearch-ml-plugin/

Issues Resolved

Related:

  1. add groupId to pluginzip publication ml-commons#468
  2. opensearch.opensearchplugin add groupID field to org.opensearch.plugin ml-commons#412

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: John Mazanec <jmazane@amazon.com>
@jmazanec15 jmazanec15 requested a review from a team October 25, 2022 16:38
@jmazanec15 jmazanec15 added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Oct 25, 2022
@jmazanec15 jmazanec15 merged commit 38de48d into opensearch-project:main Oct 25, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 25, 2022
Signed-off-by: John Mazanec <jmazane@amazon.com>
(cherry picked from commit 38de48d)
jmazanec15 pushed a commit that referenced this pull request Oct 25, 2022
Signed-off-by: John Mazanec <jmazane@amazon.com>
(cherry picked from commit 38de48d)
@jmazanec15 jmazanec15 added Bug Fixes Changes to a system or product designed to handle a programming bug/glitch Infrastructure and removed Bug Fixes Changes to a system or product designed to handle a programming bug/glitch labels Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants