[Backport 2.x] Fixed Hybrid query for cases when it's wrapped into other compound queries (#498) #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
…eries (opensearch-project#498) * Fixed nested field case Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 3991fe7) Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
force-pushed
the
backport/backport-498-to-2.x
branch
from
c71bcbf to
e0d8337
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #501 +/- ##
============================================
- Coverage 85.53% 85.41% -0.13%
- Complexity 516 540 +24
============================================
Files 40 40
Lines 1521 1563 +42
Branches 238 248 +10
============================================
+ Hits 1301 1335 +34
Misses 112 112
- Partials 108 116 +8 ☔ View full report in Codecov by Sentry. |
heemin32
approved these changes
Dec 1, 2023
vibrantvarun
approved these changes
Dec 1, 2023
navneet1v
approved these changes
Dec 1, 2023
martin-gaievski
merged commit 27a38cb
into
opensearch-project:2.x
12 of 14 checks passed
martin-gaievski
added a commit
to martin-gaievski/neural-search
that referenced
this pull request
Dec 8, 2023
…eries (opensearch-project#498) (opensearch-project#501) * Fixed nested field case (cherry picked from commit 3991fe7) Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 27a38cb) Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of commit 3991fe7 from #498 to 2.x
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.