-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BWC tests neural search #515
Conversation
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
=========================================
Coverage 84.33% 84.33%
Complexity 533 533
=========================================
Files 40 40
Lines 1564 1564
Branches 244 244
=========================================
Hits 1319 1319
Misses 133 133
Partials 112 112 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments. Overall code looks good.
Great effort in adding the spotlessCheck this was long pending. Code looks in awesome shape now.
...ng-upgrade/src/test/java/org/opensearch/neuralsearch/bwc/AbstractRollingUpgradeTestCase.java
Outdated
Show resolved
Hide resolved
qa/restart-upgrade/src/test/java/org/opensearch/neuralsearch/bwc/SemanticSearchIT.java
Outdated
Show resolved
Hide resolved
qa/restart-upgrade/src/test/resources/processor/IndexMappings.json
Outdated
Show resolved
Hide resolved
qa/restart-upgrade/src/test/resources/processor/PipelineConfiguration.json
Show resolved
Hide resolved
qa/rolling-upgrade/src/test/java/org/opensearch/neuralsearch/bwc/SemanticSearchIT.java
Outdated
Show resolved
Hide resolved
qa/rolling-upgrade/src/test/resources/processor/IndexMappings.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-515-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ff3862250ccdae41798fe0787d4872a9b07ffe2d
# Push it to GitHub
git push --set-upstream origin backport/backport-515-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…ch-project#515) * Reformatting test package Signed-off-by: Varun Jain <varunudr@amazon.com> * Initial commit of BWC Test Signed-off-by: Varun Jain <varunudr@amazon.com> * Text Search Signed-off-by: Varun Jain <varunudr@amazon.com> * Fixing bug Signed-off-by: Varun Jain <varunudr@amazon.com> * Text Search bug fix Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding windows platform in bwc Signed-off-by: Varun Jain <varunudr@amazon.com> * Adding windows platform in bwc Signed-off-by: Varun Jain <varunudr@amazon.com> * Rolling Upgrade tests Signed-off-by: Varun Jain <varunudr@amazon.com> * Bux Fix in rolling upgrade Signed-off-by: Varun Jain <varunudr@amazon.com> * Bug Fix Rolling Upgrade Signed-off-by: Varun Jain <varunudr@amazon.com> * Fixing Flaky tests Signed-off-by: Varun Jain <varunudr@amazon.com> * Updating BWC version to latest Signed-off-by: Varun Jain <varunudr@amazon.com> * Fixing bwc test Signed-off-by: Varun Jain <varunudr@amazon.com> * Semantic Search Signed-off-by: Varun Jain <varunudr@amazon.com> * Bug Fix Signed-off-by: Varun Jain <varunudr@amazon.com> * Debugging Signed-off-by: Varun Jain <varunudr@amazon.com> * Bug Fix Signed-off-by: Varun Jain <varunudr@amazon.com> * Increase memory in nodes Signed-off-by: Varun Jain <varunudr@amazon.com> * Removing extra logging Signed-off-by: Varun Jain <varunudr@amazon.com> * Cleaning up Signed-off-by: Varun Jain <varunudr@amazon.com> * Updating Pipeline Configuration Signed-off-by: Varun Jain <varunudr@amazon.com> * Remove KNN delete models Signed-off-by: Varun Jain <varunudr@amazon.com> * Remove unecessary KNN code Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing comments of naveen Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing comments of naveen Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing comments of Naveen Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing martin comments Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing comments of martin Signed-off-by: Varun Jain <varunudr@amazon.com> * Apply formatting.xml in all lines Signed-off-by: Varun Jain <varunudr@amazon.com> * Removing extra spacess from formatting.gradle Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing martin comment Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing Jack comments Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing Jack comments Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing Jack's comments Signed-off-by: Varun Jain <varunudr@amazon.com> * Fixing Test cases Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing comments of Navneet Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing comments of Navneet Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing comments of Navneet Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing comments of Navneet Signed-off-by: Varun Jain <varunudr@amazon.com> * Removing extra parameter from createPipelineProcessor Signed-off-by: Varun Jain <varunudr@amazon.com> * Fixing bug Signed-off-by: Varun Jain <varunudr@amazon.com> * Increasing number of shards Signed-off-by: Varun Jain <varunudr@amazon.com> * Bug fix of load model id Signed-off-by: Varun Jain <varunudr@amazon.com> * Changing names of tests to TextEmbeddingPRocessor Signed-off-by: Varun Jain <varunudr@amazon.com> * Updating indexes and replicas Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com>
* Initial commit for adding BWC tests in neural search plugin (#515) Signed-off-by: Varun Jain <varunudr@amazon.com>
This PR also adds the feature request from #530 |
Description
Neural search transforms text into vectors and facilitates vector search both at ingestion time and at search time. During ingestion, neural search transforms document text into vector embeddings and indexes both the text and its vector embeddings in a vector index. When you use a neural query during search, neural search converts the query text into vector embeddings, uses vector search to compare the query and document embeddings, and returns the closest results.
Before you ingest documents into an index, documents are passed through a machine learning (ML) model, which generates vector embeddings for the document fields. When you send a search request, the query text or image is also passed through the ML model, which generates the corresponding vector embeddings. Then neural search performs a vector search on the embeddings and returns matching documents.
BWC stands for Backward Compatibility.
Since, neural search feature is launched there are many features added to it. Therefore, there is a need to write BWC tests for the plugin to maintain compatibility with older versions.
This PR contains
Moreover, in this PR I have added work to format the entire project by apply ./gradlew spotlessApply to all files and remove empty new lines new lines added below. This will do the following
Issues Resolved
202
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.