Remove batch_size of bulk API from tests & refactor BWC version check #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
chishui
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es,
vibrantvarun and
zhichao-aws
as code owners
zhichao-aws
reviewed
Aug 2, 2024
...ng-upgrade/src/test/resources/processor/PipelineForSparseEncodingProcessorConfiguration.json
Outdated
Show resolved
Hide resolved
src/test/resources/processor/SparseEncodingPipelineConfiguration.json
Outdated
Show resolved
Hide resolved
zane-neo
reviewed
Aug 2, 2024
...pgrade/src/test/java/org/opensearch/neuralsearch/bwc/AbstractRestartUpgradeRestTestCase.java
Outdated
Show resolved
Hide resolved
zane-neo
reviewed
Aug 2, 2024
| @@ -124,13 +124,25 @@ protected String uploadSparseEncodingModel() throws Exception { | |||
| return registerModelGroupAndGetModelId(requestBody); | |||
| } | |||
|
|
|||
| protected void createPipelineForSparseEncodingProcessor(String modelId, String pipelineName) throws Exception { | |||
| protected void createPipelineForSparseEncodingProcessor(String modelId, String pipelineName, Integer batchSize) throws Exception { | |||
There was a problem hiding this comment.
Looks like repeating code, is there any opportunity to optimize this?
There was a problem hiding this comment.
Too many functions are duplicate between these two bwc files, I think we need dedicated work to refactor
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
zhichao-aws
approved these changes
Aug 22, 2024
zane-neo
approved these changes
Aug 23, 2024
zane-neo
added
the
backport 2.x
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
…#852) * Remove batch_size of bulk API from tests & refactor BWC version check Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Update changelog Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Address some comments Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Update Changelog Signed-off-by: Liyun Xiu <xiliyun@amazon.com> --------- Signed-off-by: Liyun Xiu <xiliyun@amazon.com> (cherry picked from commit e1c3878)
martin-gaievski
pushed a commit
that referenced
this pull request
Oct 23, 2024
…#852) * Remove batch_size of bulk API from tests & refactor BWC version check Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Update changelog Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Address some comments Signed-off-by: Liyun Xiu <xiliyun@amazon.com> * Update Changelog Signed-off-by: Liyun Xiu <xiliyun@amazon.com> --------- Signed-off-by: Liyun Xiu <xiliyun@amazon.com> (cherry picked from commit e1c3878) Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
batch_sizeof bulk API from testsbatch_sizein processorRelated Issues
Resolves opensearch-project/OpenSearch#14283
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.