[Backport 2.x] ByFieldRerank Processor (ReRankProcessor enhancement) #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject#932) * Implements initial By Field re rank Signed-off-by: Brian Flores <iflorbri@amazon.com>
Signed-off-by: Brian Flores <iflorbri@amazon.com>
Spotless apply was runned and gradlew check which runs ITs and UT Signed-off-by: Brian Flores <iflorbri@amazon.com>
brianf-aws
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es and
vibrantvarun
as code owners
brianf-aws
changed the title
vibrantvarun
approved these changes
Oct 22, 2024
martin-gaievski
approved these changes
Oct 22, 2024
martin-gaievski
merged commit 858ff28
into
opensearch-project:2.x
112 of 144 checks passed
martin-gaievski
added a commit
that referenced
this pull request
Oct 22, 2024
…960) (#962) * ByFieldRerank Processor (ReRankProcessor enhancement) (#932) Signed-off-by: Brian Flores <iflorbri@amazon.com> (cherry picked from commit 858ff28) Signed-off-by: Martin Gaievski <gaievski@amazon.com> Co-authored-by: Brian Flores <iflorbri@amazon.com> Co-authored-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes backport issues (Spotless apply bug, Java syntax was changed to match older version)
Testing
./gradlew spotlessApplyand./gradlew check(test IT and UT)Resolves
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.