Incremented version to 2.1.1. #478
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.1 #478 +/- ##
=========================================
Coverage 71.01% 71.01%
Complexity 112 112
=========================================
Files 124 124
Lines 3923 3923
Branches 613 613
=========================================
Hits 2786 2786
Misses 961 961
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -64,7 +64,7 @@ dependencies { | |||
| } // ${kotlin_version} does not work for coroutines | |||
| implementation "${group}:common-utils:${common_utils_version}" | |||
| // TODO: change compile to implementation when the _local/stats API is supported | |||
| compileOnly "org.json:json:20180813" | |||
| compileOnly "org.json:json:2.1.1813" | |||
There was a problem hiding this comment.
Looks like there are compile failures because it can't find that version of json. Would you be able to check to see if it was correctly defined?
There was a problem hiding this comment.
This was auto updated. Should I revert this?
There was a problem hiding this comment.
Yeah, if it's not necessary you can revert it. Also please rebase your branch since this PR has been open for a while.
There was a problem hiding this comment.
I did rebase but since this branch's base is 2.1 I think not much changes were backported. Also I replicated what you did in #493
Locally gradle build was successful. Let's see if this goes through. Not sure if the mockito version change should be in this version
There was a problem hiding this comment.
Yeah, I think it was one change that was added that shouldn't affect this PR but just wanted to be sure the test run is an accurate reflection of the current state.
There was a problem hiding this comment.
Looks like it passed now. Can you review the changes? Thanks!
Signed-off-by: Sayali Rohidas Gaikawad <gaiksaya@amazon.com>
Signed-off-by: Sayali Rohidas Gaikawad <gaiksaya@amazon.com>
gaiksaya
force-pushed
the
increment-to-2.1.1
branch
from
e4a7b81 to
7227b6e
Compare
Signed-off-by: Sayali Rohidas Gaikawad <gaiksaya@amazon.com>
|
@gaiksaya Would you mind updating this in your PR as well to be You can ignore the |
Signed-off-by: Sayali Rohidas Gaikawad <gaiksaya@amazon.com>
|
@qreshi Would it be worthwhile to backport this bump to |
|
@AWSHurneyt No, I think patch level version bumps should happen in the branch for the version itself ( |
Sounds good, just wanted to get your thoughts. |
Coming from opensearch-project/opensearch-build#1818 post release activities.