Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish snapshots to maven via GHA #627

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Publish snapshots to maven via GHA #627

merged 5 commits into from
Feb 21, 2023

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Feb 21, 2023 •
edited
Loading

Description

Publish snapshots to maven via GHA

Issues Resolved

#620

Testing:

find notifications/snapshots | sort
notifications/snapshots
notifications/snapshots/org
notifications/snapshots/org/opensearch
notifications/snapshots/org/opensearch/plugin
notifications/snapshots/org/opensearch/plugin/notifications
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/maven-metadata.xml
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/maven-metadata.xml.md5
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha1
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha256
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha512
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/notifications-3.0.0.0-20230221.175731-1.pom
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/notifications-3.0.0.0-20230221.175731-1.pom.md5
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/notifications-3.0.0.0-20230221.175731-1.pom.sha1
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/notifications-3.0.0.0-20230221.175731-1.pom.sha256
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/notifications-3.0.0.0-20230221.175731-1.pom.sha512
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/notifications-3.0.0.0-20230221.175731-1.zip
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/notifications-3.0.0.0-20230221.175731-1.zip.md5
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/notifications-3.0.0.0-20230221.175731-1.zip.sha1
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/notifications-3.0.0.0-20230221.175731-1.zip.sha256
notifications/snapshots/org/opensearch/plugin/notifications/3.0.0.0-SNAPSHOT/notifications-3.0.0.0-20230221.175731-1.zip.sha512
notifications/snapshots/org/opensearch/plugin/notifications/maven-metadata.xml
notifications/snapshots/org/opensearch/plugin/notifications/maven-metadata.xml.md5
notifications/snapshots/org/opensearch/plugin/notifications/maven-metadata.xml.sha1
notifications/snapshots/org/opensearch/plugin/notifications/maven-metadata.xml.sha256
notifications/snapshots/org/opensearch/plugin/notifications/maven-metadata.xml.sha512

find core/snapshots | sort
core/snapshots
core/snapshots/org
core/snapshots/org/opensearch
core/snapshots/org/opensearch/plugin
core/snapshots/org/opensearch/plugin/opensearch-notifications-core
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/maven-metadata.xml
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/maven-metadata.xml.md5
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha1
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha256
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha512
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/opensearch-notifications-core-3.0.0.0-20230221.175731-1.pom
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/opensearch-notifications-core-3.0.0.0-20230221.175731-1.pom.md5
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/opensearch-notifications-core-3.0.0.0-20230221.175731-1.pom.sha1
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/opensearch-notifications-core-3.0.0.0-20230221.175731-1.pom.sha256
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/opensearch-notifications-core-3.0.0.0-20230221.175731-1.pom.sha512
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/opensearch-notifications-core-3.0.0.0-20230221.175731-1.zip
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/opensearch-notifications-core-3.0.0.0-20230221.175731-1.zip.md5
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/opensearch-notifications-core-3.0.0.0-20230221.175731-1.zip.sha1
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/opensearch-notifications-core-3.0.0.0-20230221.175731-1.zip.sha256
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/3.0.0.0-SNAPSHOT/opensearch-notifications-core-3.0.0.0-20230221.175731-1.zip.sha512
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/maven-metadata.xml
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/maven-metadata.xml.md5
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/maven-metadata.xml.sha1
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/maven-metadata.xml.sha256
core/snapshots/org/opensearch/plugin/opensearch-notifications-core/maven-metadata.xml.sha512

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago
Publish snapshots to maven
00059ac 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago
fix
28c5ca7 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago lezzago requested review from a team and gaiksaya February 21, 2023 14:28
gaiksaya
gaiksaya reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post the out of all the publications in the comment just to confirm? Testing information is provided in the issue
Thanks!

.github/workflows/maven-publish.yml Outdated Show resolved Hide resolved
@lezzago
update workflow
570ef44 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago
remove maven publish from core-spi
b0f9962 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
gaiksaya
gaiksaya reviewed Feb 21, 2023
View reviewed changes
.github/workflows/maven-publish.yml Outdated
Comment on lines 17 to 18
jdk: [17]
platform: ["ubuntu-latest"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Since it is just one value you can remove the matrix.

@gaiksaya
Copy link
Member

Added the role in secrets! Thanks!

getsaurabh02
getsaurabh02 previously approved these changes Feb 21, 2023
View reviewed changes
@lezzago
clean workflow
23405dd 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@lezzago lezzago merged commit a3d37f4 into opensearch-project:main Feb 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2023
@lezzago @github-actions
Publish snapshots to maven via GHA (#627)
f44e699 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit a3d37f4)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 21, 2023
Merged
lezzago added a commit that referenced this pull request Feb 21, 2023
@opensearch-trigger-bot @lezzago
Publish snapshots to maven via GHA (#627) (#628)
3c57da5 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit a3d37f4)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
opensearch-trigger-bot bot added a commit that referenced this pull request May 18, 2023
@opensearch-trigger-bot @github-actions
Publish snapshots to maven via GHA (#627) (#628)
7934bf2 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit a3d37f4)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 3c57da5)
xluo-aws pushed a commit that referenced this pull request May 18, 2023
@opensearch-trigger-bot
Publish snapshots to maven via GHA (#627) (#628) (#678)
25542b3 
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit a3d37f4)

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
(cherry picked from commit 3c57da5)

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaiksaya gaiksaya gaiksaya approved these changes

@getsaurabh02 getsaurabh02 getsaurabh02 approved these changes

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lezzago @gaiksaya @getsaurabh02