Skip to content

Commit

Permalink
remove span months/quarters (#1257)
Browse files Browse the repository at this point in the history 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
  • Loading branch information
@ps48
ps48 authored Nov 4, 2022
1 parent 75e74f6 commit 0ea635a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 116 deletions.
4 changes: 2 additions & 2 deletions dashboards-observability/common/constants/metrics.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export const resolutionOptions = [
{ value: 'm', text: 'minutes' },
{ value: 'h', text: 'hours' },
{ value: 'd', text: 'days' },
{ value: 'M', text: 'Months' },
{ value: 'q', text: 'quarters' },
// { value: 'M', text: 'Months' },
// { value: 'q', text: 'quarters' },
{ value: 'y', text: 'years' },
];

Expand Down
12 changes: 6 additions & 6 deletions ...rvability/public/components/metrics/sidebar/__tests__/__snapshots__/sidebar.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
initialIsOpen={true}
isLoading={false}
isLoadingMessage={false}
paddingSize="xs"
paddingSize="none"
>
<div
className="euiAccordion euiAccordion-isOpen"
Expand Down Expand Up @@ -197,7 +197,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
>
<div>
<div
className="euiAccordion__padding--xs"
className=""
>
<ul
className="metricsList"
Expand Down Expand Up @@ -230,7 +230,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
initialIsOpen={true}
isLoading={false}
isLoadingMessage={false}
paddingSize="xs"
paddingSize="none"
>
<div
className="euiAccordion euiAccordion-isOpen"
Expand Down Expand Up @@ -302,7 +302,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
>
<div>
<div
className="euiAccordion__padding--xs"
className=""
>
<ul
className="metricsList"
Expand Down Expand Up @@ -335,7 +335,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
initialIsOpen={true}
isLoading={false}
isLoadingMessage={false}
paddingSize="xs"
paddingSize="none"
>
<div
className="euiAccordion euiAccordion-isOpen"
Expand Down Expand Up @@ -407,7 +407,7 @@ exports[`Side Bar Component renders Side Bar Component 1`] = `
>
<div>
<div
className="euiAccordion__padding--xs"
className=""
>
<ul
className="metricsList"
Expand Down
108 changes: 0 additions & 108 deletions ...ability/public/components/metrics/top_menu/__tests__/__snapshots__/top_menu.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -274,14 +274,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled in
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -323,14 +315,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled in
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -396,14 +380,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled in
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -465,18 +441,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled in
</option>
<option
key="4"
value="M"
>
Months
</option>
<option
key="5"
value="q"
>
quarters
</option>
<option
key="6"
value="y"
>
years
Expand Down Expand Up @@ -1631,14 +1595,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled wit
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -1680,14 +1636,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled wit
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -1753,14 +1701,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled wit
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -1822,18 +1762,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when disabled wit
</option>
<option
key="4"
value="M"
>
Months
</option>
<option
key="5"
value="q"
>
quarters
</option>
<option
key="6"
value="y"
>
years
Expand Down Expand Up @@ -2934,14 +2862,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when enabled 1`]
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -2983,14 +2903,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when enabled 1`]
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -3056,14 +2968,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when enabled 1`]
"text": "days",
"value": "d",
},
Object {
"text": "Months",
"value": "M",
},
Object {
"text": "quarters",
"value": "q",
},
Object {
"text": "years",
"value": "y",
Expand Down Expand Up @@ -3125,18 +3029,6 @@ exports[`Metrics Top Menu Component renders Top Menu Component when enabled 1`]
</option>
<option
key="4"
value="M"
>
Months
</option>
<option
key="5"
value="q"
>
quarters
</option>
<option
key="6"
value="y"
>
years
Expand Down

0 comments on commit 0ea635a

Please sign in to comment.