Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump detekt version to 1.21.0 #1226

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Bump detekt version to 1.21.0 #1226

merged 2 commits into from
Nov 4, 2022

Conversation

rupal-bq
Copy link
Contributor

@rupal-bq rupal-bq commented Nov 2, 2022

Signed-off-by: Rupal Mahajan maharup@amazon.com

Description

  • Upgrade detekt version to 1.21.0.
  • Add snakeyaml v1.32 to resolution.

Issues Resolved

CVE-2022-0272
CVE-2022-25857
CVE-2022-38750
CVE-2022-38749
CVE-2022-38751
CVE-2022-38752

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
@rupal-bq rupal-bq requested a review from a team as a code owner November 2, 2022 18:10
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022

Codecov Report

Merging #1226 (c27dc22) into 2.4 (b6139c4) will increase coverage by 18.20%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##                2.4    #1226       +/-   ##
=============================================
+ Coverage     53.57%   71.78%   +18.20%     
  Complexity      291      291               
=============================================
  Files           282       42      -240     
  Lines          9548     2314     -7234     
  Branches       2247      240     -2007     
=============================================
- Hits           5115     1661     -3454     
+ Misses         4262      512     -3750     
+ Partials        171      141       -30     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 71.78% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ensearch/observability/index/ObservabilityIndex.kt 56.47% <0.00%> (-1.37%) ⬇️
...ch/observability/index/ObservabilityQueryHelper.kt 57.40% <ø> (+1.04%) ⬆️
...pensearch/observability/security/SecurityAccess.kt 0.00% <0.00%> (ø)
...pensearch/observability/settings/PluginSettings.kt 74.71% <0.00%> (ø)
...ents/visualizations/charts/logs_view/logs_view.tsx
...ic/components/custom_panels/custom_panel_table.tsx
...rds-observability/common/utils/settings_service.ts
...config_panes/config_controls/config_text_input.tsx
...event_analytics/explorer/save_panel/save_panel.tsx
...components/event_analytics/explorer/no_results.tsx
... and 234 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

joshuali925
joshuali925 previously approved these changes Nov 2, 2022
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
@joshuali925 joshuali925 merged commit 03b62c2 into opensearch-project:2.4 Nov 4, 2022
mengweieric pushed a commit to mengweieric/observability that referenced this pull request Nov 30, 2022
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
@mengweieric mengweieric mentioned this pull request Dec 1, 2022
6 tasks
mengweieric added a commit that referenced this pull request Dec 1, 2022
* Update detekt version (#1226)

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* some changes needed to pass build pipeline

Signed-off-by: Eric Wei <menwe@amazon.com>

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Rupal Mahajan <maharup@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 1, 2022
* Update detekt version (#1226)

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* some changes needed to pass build pipeline

Signed-off-by: Eric Wei <menwe@amazon.com>

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Rupal Mahajan <maharup@amazon.com>
(cherry picked from commit 982ff60)
mengweieric added a commit that referenced this pull request Dec 1, 2022
* Update detekt version (#1226)

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* some changes needed to pass build pipeline

Signed-off-by: Eric Wei <menwe@amazon.com>

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Rupal Mahajan <maharup@amazon.com>
(cherry picked from commit 982ff60)

Co-authored-by: Eric Wei <menwe@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants