Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimatch to v3.0.5 #1228

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Bump minimatch to v3.0.5 #1228

merged 1 commit into from
Nov 3, 2022

Conversation

rupal-bq
Copy link
Contributor

@rupal-bq rupal-bq commented Nov 2, 2022

Signed-off-by: Rupal maharup@amazon.com

Description

Added minimatch to resolutions for resolving CVE-2022-3517

Issues Resolved

CVE-2022-3517

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rupal <maharup@ip-172-31-16-59.us-west-2.compute.internal>
@rupal-bq rupal-bq requested a review from a team as a code owner November 2, 2022 19:07
@codecov-commenter
Copy link

Codecov Report

Merging #1228 (a906311) into 2.4 (b6139c4) will increase coverage by 18.30%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.4    #1228       +/-   ##
=============================================
+ Coverage     53.57%   71.87%   +18.30%     
  Complexity      291      291               
=============================================
  Files           282       42      -240     
  Lines          9548     2311     -7237     
  Branches       2247      240     -2007     
=============================================
- Hits           5115     1661     -3454     
+ Misses         4262      509     -3753     
+ Partials        171      141       -30     
Flag Coverage Δ
dashboards-observability ?
opensearch-observability 71.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ents/common/helpers/ppl_docs/functions/datetime.ts
...panes/config_controls/config_line_chart_styles.tsx
...event_analytics/hooks/use_render_visualizations.ts
...isualizations/shared_components/toolbar_button.tsx
...ility/public/framework/redux/store/shared_state.ts
...ytics/components/common/filters/filter_helpers.tsx
...ic/components/common/field_button/field_button.tsx
...ic/components/common/field_name/field_type_name.ts
...ponents/common/helpers/ppl_docs/commands/search.ts
.../explorer/events_views/trace_block/trace_block.tsx
... and 230 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuali925 joshuali925 merged commit 0224c23 into opensearch-project:2.4 Nov 3, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-1228-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0224c23ff71ea5d5ee25738cf8e63842556e8eeb
# Push it to GitHub
git push --set-upstream origin backport/backport-1228-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-1228-to-1.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1228-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0224c23ff71ea5d5ee25738cf8e63842556e8eeb
# Push it to GitHub
git push --set-upstream origin backport/backport-1228-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-1228-to-1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants