-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for app analytics crash #1255
Merged
mengweieric
merged 4 commits into
opensearch-project:2.4
from
mengweieric:issue/app-analytics-crash-fix
Nov 4, 2022
Merged
Fix for app analytics crash #1255
mengweieric
merged 4 commits into
opensearch-project:2.4
from
mengweieric:issue/app-analytics-crash-fix
Nov 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Wei <menwe@amazon.com>
sejli
previously approved these changes
Nov 4, 2022
joshuali925
previously approved these changes
Nov 4, 2022
Signed-off-by: Eric Wei <menwe@amazon.com>
joshuali925
previously approved these changes
Nov 4, 2022
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 2.4 #1255 +/- ##
=============================================
- Coverage 70.27% 55.05% -15.22%
Complexity 292 292
=============================================
Files 42 294 +252
Lines 2395 10180 +7785
Branches 248 2343 +2095
=============================================
+ Hits 1683 5605 +3922
- Misses 571 4403 +3832
- Partials 141 172 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshuali925
approved these changes
Nov 4, 2022
ps48
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Wei menwe@amazon.com
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.