Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for app analytics crash #1255

Merged

Conversation

mengweieric
Copy link
Collaborator

Signed-off-by: Eric Wei menwe@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric mengweieric requested a review from a team as a code owner November 4, 2022 17:12
sejli
sejli previously approved these changes Nov 4, 2022
joshuali925
joshuali925 previously approved these changes Nov 4, 2022
Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric mengweieric dismissed stale reviews from joshuali925 and sejli via b3fe3c5 November 4, 2022 17:31
joshuali925
joshuali925 previously approved these changes Nov 4, 2022
Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric Wei <menwe@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #1255 (e897f3d) into 2.4 (75e74f6) will decrease coverage by 15.21%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.4    #1255       +/-   ##
=============================================
- Coverage     70.27%   55.05%   -15.22%     
  Complexity      292      292               
=============================================
  Files            42      294      +252     
  Lines          2395    10180     +7785     
  Branches        248     2343     +2095     
=============================================
+ Hits           1683     5605     +3922     
- Misses          571     4403     +3832     
- Partials        141      172       +31     
Flag Coverage Δ
dashboards-observability 50.37% <ø> (?)
opensearch-observability 70.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/components/visualizations/charts/bar/bar_type.ts 100.00% <ø> (ø)
...isualizations/charts/data_table/data_table_type.ts 100.00% <ø> (ø)
...omponents/visualizations/charts/lines/line_type.ts 77.77% <ø> (ø)
...c/components/visualizations/charts/pie/pie_type.ts 100.00% <ø> (ø)
...s/event_analytics/redux/reducers/fetch_reducers.ts 50.00% <0.00%> (ø)
...mon/query_manager/query_parser/ppl_query_parser.ts 100.00% <0.00%> (ø)
...nents/helpers/__tests__/sampleDefaultNotebooks.tsx 100.00% <0.00%> (ø)
.../visualizations/charts/logs_view/logs_view_type.ts 100.00% <0.00%> (ø)
...ards-observability/public/services/requests/dsl.ts 45.45% <0.00%> (ø)
...ashboards-observability/common/constants/shared.ts 100.00% <0.00%> (ø)
... and 246 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mengweieric mengweieric merged commit 0bee8e7 into opensearch-project:2.4 Nov 4, 2022
@mengweieric mengweieric deleted the issue/app-analytics-crash-fix branch November 4, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants