Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sso metrics & traces schema #1427

Merged
merged 228 commits into from
Feb 22, 2023
Merged

Support sso metrics & traces schema #1427

merged 228 commits into from
Feb 22, 2023

Conversation

YANG-DB
Copy link
Member

@YANG-DB YANG-DB commented Feb 22, 2023

Description

Simple Schema for Observability - SSO - will support the 3 major Observability types:

  • Traces
  • Logs
  • Metrics

SSO will comply with the OTEL schema and continue supporting proprietary index structure

Content

In addition to the simple schema for Observability metrics signal definition, this PR creates the following during Plugin initiation:

  • Observability Metrics index template
  • Observability Traces index template

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ps48 and others added 30 commits April 19, 2022 11:55
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>
* [OSD][Tests] add test subject to app title for app analytics

Using a test subject we can find the specific element instead
of trying to search the DOM for the class and hope the class
is the right class that contains the element we are looking for.

We can search the dom for this specific test subject and actually
make the test runner wait until this test subject exists before
executing the tests.

Issue related:
#679

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update one example for cypress tests

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
* Bump prismjs from 1.25.0 to 1.27.0 in /dashboards-observability (#508) (#574)

Bumps [prismjs](https://github.com/PrismJS/prism) from 1.25.0 to 1.27.0.
- [Release notes](https://github.com/PrismJS/prism/releases)
- [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md)
- [Commits](PrismJS/prism@v1.25.0...v1.27.0)

---
updated-dependencies:
- dependency-name: prismjs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
(cherry picked from commit b4f491a)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* change to support java 8 in compile and runtime (#575) (#576)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit 5c43e9d)

Co-authored-by: Zhongnan Su <szhongna@amazon.com>

* Add 1.3.0 release notes (#580) (#582)

Signed-off-by: Eugene Lee <eugenesk@amazon.com>

* bug fixes

Signed-off-by: Eric Wei <menwe@amazon.com>

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: vamsi-amazon <reddyvam@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
Signed-off-by: Eugene Lee <eugenesk@amazon.com>
…775)

* Added cypress test cases for tooltip and search engine on Trace dashboard

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added test cases for filters

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added cypress test cases for tooltip and search engine on Trace dashboard

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added test cases for filters

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added test cases for Service page in Trace analytics

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added Cypress test cases for trace analytics services spans table

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* Cypress test case for Traces

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Cypress test case for Traces Updated

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Worked on review comments

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

Co-authored-by: Deepak Nevde <deepak_nevde@persistent.com>
Co-authored-by: Nidhi Singhai <nidhi_singhai@persistent.com>
* rendered default axes selected and added error toasts on Save and Apply click if invalid value option selected

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* Cypress changes for error toasts on invalid value options selected

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* added constant VIZ_CONTAIN_XY_AXIS for x, y value axis

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>
* Initial commit for treemap visualization

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* changes to labelField, layout and config

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* reverted changes of layoutConfig

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* Cypress TestCase for TreeMap

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* added new line

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* updated test cases

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* reverted snapshots

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* implemented treemap config options

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* added multicolored theme option

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* updated snapshots

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* Updated test scripts for multicolored section

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Fixed default selection for treemap

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

Co-authored-by: Nidhi Singhai <nidhi_singhai@persistent.com>
Co-authored-by: Pratibha Pandey <pratibha_pandey@persistent.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
* Added test cases for Notebooks application

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>

* Added test cases for empty state of Notebooks table

Signed-off-by: Pratibha Pandey <pratibha_pandey@persistent.com>
…ases for same. (#776)

* pie chart legends, chart color contrast and cypress test cases

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* Added color code in constants

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* Snapshots updated

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* Conflicts resolved

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* Review comment addressed

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>

* color variable changes

Signed-off-by: Deepak Nevde <deepak_nevde@persistent.com>
* Implementation of color theme for heatmap

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

* refactoring code

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

* HeatMap Cypress TestCase

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Cypress TestCase for HeatMap

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Update Done according to Comment

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Refactored code

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

* Updated snapshot test case

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

* Fixed toast implementation and no result found for heatmap

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

* Undefined checks for value options

Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

Co-authored-by: Nidhi Singhai <nidhi_singhai@persistent.com>
* updated dimensions and metrics UI for pie chart

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* updated imports

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* updated snapshots

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>
* added support for multiple parents in treemap

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* minor type and position fixes

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* added default values for color pickers

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* resolved review comments

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* TreeMap Enhancement TestCases

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* TreeMap Enhancement TestCases

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* TreeMap Enhancement TestCases Updated

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* Update Done

Signed-off-by: Nidhi Singhai <nidhi_singhai@persistent.com>

* fixed default parent color pickers state

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* fixed undefined check

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

* updated snapshots

Signed-off-by: Mrunal Zambre <mrunal_zambre@persistent.com>

Co-authored-by: Nidhi Singhai <nidhi_singhai@persistent.com>
Co-authored-by: Subrat Pattnaik <subrat.pattnaik@hotmail.com>
…ion on config panel - 697 (#780)

* mode, orientation and rotate labels implementation under Chart style for Bar chart

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx

* LineWidth and Fill-opacity changes

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/utils/utils.tsx

* Bar Group Width, Bar Width changes and rotated label hiding issue resolved

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* corner cases handled for bar with and group Width and conditionally rendered rotate label UI

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* Bar chart legend and color theme changes

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_legend.tsx

* Snapshots updated

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* empty line added

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_legend.tsx

* review comment addressed

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_legend.tsx

* snapshot updated

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* PR review comment addressed.

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

# Conflicts:
#	dashboards-observability/public/components/event_analytics/explorer/visualizations/config_panel/config_panes/config_controls/config_button_group.tsx

* add button constant added

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* changed rgba to rgb in bar.tsx

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>

* snapshot updated

Signed-off-by: rinku-kumar-psl <rinku_kumar@persistent.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
* change version bump to maintenance

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* change version bump to maintenance

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
YANG-DB and others added 15 commits February 21, 2023 09:54
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
* Add publish snapshots to maven via GHA

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

* Add rootProject name in seetings.gradle to change plugin name to opensearch-observability

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

---------

Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
# Conflicts:
#	.github/workflows/opensearch-observability-test-and-build-workflow.yml
#	build.gradle
#	src/main/kotlin/org/opensearch/observability/metrics/Metrics.kt
#	src/test/kotlin/org/opensearch/observability/PluginRestTestCase.kt
#	src/test/resources/security/sample.pem
…Taces_schema

# Conflicts:
#	src/test/kotlin/org/opensearch/observability/PluginRestTestCase.kt
…ces_schema

# Conflicts:
#	schema/traces/README.md
#	schema/traces/samples/traceA.json
#	schema/traces/samples/traceB.json
#	schema/traces/samples/traceC.json
#	schema/traces/traces.mapping
#	schema/traces/traces.schema
#	src/main/kotlin/org/opensearch/observability/ObservabilityPlugin.kt
#	src/test/kotlin/org/opensearch/observability/rest/AssemblyValidationIT.kt
as part of the responsibilities of the Observability plugin it would load the index template for the observability type as part of its bootstrap

Signed-off-by: YANGDB <yang.db.dev@gmail.com>
add @timestamp for trace samples
Signed-off-by: YANGDB <yang.db.dev@gmail.com>

Signed-off-by: YANGDB <yang.db.dev@gmail.com>
…' into Support_SSO_Metrics_Taces_schema

# Conflicts:
#	schema/traces/samples/traceA.json
#	schema/traces/samples/traceB.json
#	schema/traces/samples/traceC.json
Signed-off-by: YANGDB <yang.db.dev@gmail.com>
@YANG-DB YANG-DB added documentation Improvements or additions to documentation v2.6.0 labels Feb 22, 2023
@YANG-DB YANG-DB marked this pull request as ready for review February 22, 2023 21:02
@YANG-DB YANG-DB requested a review from a team as a code owner February 22, 2023 21:02
@YANG-DB YANG-DB merged commit e8b6fd4 into opensearch-project:2.6 Feb 22, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-main main
# Navigate to the new working tree
cd .worktrees/backport-main
# Create a new branch
git switch --create backport/backport-1427-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e8b6fd42039122d6ff83c6b20fe736ca5ff98b24
# Push it to GitHub
git push --set-upstream origin backport/backport-1427-to-main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-1427-to-main.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1427-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e8b6fd42039122d6ff83c6b20fe736ca5ff98b24
# Push it to GitHub
git push --set-upstream origin backport/backport-1427-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1427-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport main backport 2.x documentation Improvements or additions to documentation v2.6.0
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.