Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
  • Loading branch information
Naarcha-AWS and natebower authored Oct 25, 2024
1 parent 76ecdea commit ca4c934
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion spec/schemas/_core.mtermvectors.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ components:
_index:
$ref: '_common.yaml#/components/schemas/IndexName'
doc:
description: An artificial document for which you want to retrieve term vectors.
description: An artificial document for which you want to retrieve term vectors.
type: object
fields:
$ref: '_common.yaml#/components/schemas/Fields'
Expand Down
10 changes: 5 additions & 5 deletions spec/schemas/_core.rank_eval.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ components:
- type: object
properties:
ignore_unlabeled:
description: Controls how unlabeled documents in the search results are counted. When `true`, unlabeled documents are ignored and do not count as relevant or irrelevant. When `false`, unlabeled documents are treated as irrelevant.
description: Controls how unlabeled documents in the search results are counted. When `true`, unlabeled documents are ignored and are not treated as relevant or irrelevant. When `false`, unlabeled documents are treated as irrelevant.
type: boolean
RankEvalMetricRatingThreshold:
allOf:
Expand Down Expand Up @@ -100,7 +100,7 @@ components:
- type: object
properties:
normalize:
description: When `true`, calculates the Normalized DCG (https://en.wikipedia.org/wiki/Discounted_cumulative_gain#Normalized_DCG).
description: When `true`, calculates the [normalized discounted cumulative gain (nDCG)](https://en.wikipedia.org/wiki/Discounted_cumulative_gain#Normalized_DCG).

Check failure on line 103 in spec/schemas/_core.rank_eval.yaml

View workflow job for this annotation

GitHub Actions / check

[vale] reported by reviewdog 🐶 [OpenSearch.SpacingPunctuation] There should be no space before and one space after the punctuation mark in 'en.wikipedia'. Raw Output: {"message": "[OpenSearch.SpacingPunctuation] There should be no space before and one space after the punctuation mark in 'en.wikipedia'.", "location": {"path": "spec/schemas/_core.rank_eval.yaml", "range": {"start": {"line": 103, "column": 111}}}, "severity": "ERROR"}
type: boolean
RankEvalMetricExpectedReciprocalRank:
allOf:
Expand All @@ -119,17 +119,17 @@ components:
description: The `metric_score`, found in the `metric_details` section, shows the contribution of this query to the global quality metric score.
type: number
unrated_docs:
description: The `unrated_docs` section contains an `_index` and `_id` entry for each document that didn't have a ratings value. This can be used to ask the user to supply ratings for these documents.
description: The `unrated_docs` section contains an `_index` and `_id` entry for each document that didn't have a `ratings` value. This can be used to ask the user to supply ratings for these documents.
type: array
items:
$ref: '#/components/schemas/UnratedDocument'
hits:
description: The `hits` section shows a grouping of the search results with their supplied ratings.
description: The `hits` section provides a grouping of the search results with their supplied ratings.
type: array
items:
$ref: '#/components/schemas/RankEvalHitItem'
metric_details:
description: The `metric_details` section gives additional information about the calculated quality metric, in other words, how many of the retrieved documents were relevant. The content varies for each metric but allows for better interpretation of the results.
description: The `metric_details` section provides additional information about the calculated quality metric indicating the number of relevant retrieved documents. The content varies for each metric but allows for better interpretation of the results.
type: object
additionalProperties:
type: object
Expand Down

0 comments on commit ca4c934

Please sign in to comment.