Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds API spec for security plugin #271

Merged
merged 17 commits into from
May 10, 2024

Conversation

DarshitChanpura
Copy link
Member

Description

Corrects invalid entries and adds missing entries for the security plugin.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go through descriptions and ensure common format (missing periods at the end of sentences).

Is this ready, mark it ready for review?

spec/schemas/security._common.yaml Outdated Show resolved Hide resolved
spec/namespaces/security.yaml Outdated Show resolved Hide resolved
@DarshitChanpura
Copy link
Member Author

@dblock ty for your review. This isn't ready yet. I'm doing a final pass-through the spec file to validate grammar and previously added specs. I'll mark it as ready once all changes are complete.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Copy link
Contributor

API specs implemented for 293/649 (45%) APIs.

Copy link
Contributor

github-actions bot commented May 1, 2024

API specs implemented for 299/649 (46%) APIs.

1 similar comment
Copy link
Contributor

github-actions bot commented May 1, 2024

API specs implemented for 299/649 (46%) APIs.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Copy link
Contributor

github-actions bot commented May 1, 2024

API specs implemented for 299/649 (46%) APIs.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Copy link
Contributor

github-actions bot commented May 1, 2024

API specs implemented for 299/649 (46%) APIs.

@DarshitChanpura
Copy link
Member Author

@dblock @nhtruong This PR is ready for review.

QQ, how are we planning to test the validity of all the added specs?

@DarshitChanpura
Copy link
Member Author

A new endpoint is in the process of being added to security plugin. I will update the spec once the PR is merged in security repo: opensearch-project/security#4299

@dblock
Copy link
Member

dblock commented May 1, 2024

@dblock @nhtruong This PR is ready for review.

QQ, how are we planning to test the validity of all the added specs?

It's time for an issue!

#277

We do have a lot of tests in clients but we should add something here that exercises APIs.

Copy link
Contributor

github-actions bot commented May 2, 2024

API specs implemented for 299/649 (46%) APIs.

Copy link
Contributor

github-actions bot commented May 7, 2024

API specs implemented for 299/649 (46%) APIs.

…ibility

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Copy link
Contributor

github-actions bot commented May 8, 2024

API specs implemented for 299/649 (46%) APIs.

@nhtruong
Copy link
Collaborator

nhtruong commented May 9, 2024

@Xtansia This looks good to me but would love a 2nd pair of eyes to review this.

Copy link
Collaborator

@Xtansia Xtansia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xtansia Xtansia merged commit de939d2 into opensearch-project:main May 10, 2024
5 checks passed
@dblock
Copy link
Member

dblock commented Jun 4, 2024

@DarshitChanpura We have a new test framework in added in #299, maybe you'll be interested in writing tests for the security plugin using it?

@DarshitChanpura
Copy link
Member Author

@DarshitChanpura We have a new test framework in added in #299, maybe you'll be interested in writing tests for the security plugin using it?

Yes, I'll take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add specs for security namespace
4 participants