Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate order of superseded operations. #326

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 7, 2024

Description

Validate order of superseded operations.
Moved helpers to src, added some tests.
The src folder is already a project root, no need for relative includes.

Issues Resolved

Closes #272 together with #325.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.50%. Comparing base (e6597c0) to head (31b2e62).

Current head 31b2e62 differs from pull request most recent head 70a0c14

Please upload reports for the commit 70a0c14 to get more accurate results.

Files Patch % Lines
tools/helpers.ts 66.66% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   89.50%   89.50%   -0.01%     
==========================================
  Files          40       40              
  Lines        1172     1200      +28     
  Branches      254      298      +44     
==========================================
+ Hits         1049     1074      +25     
+ Misses        122      116       -6     
- Partials        1       10       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Changes Analysis

Commit SHA: 70a0c14
Comparing To SHA: e6597c0

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9422946413/artifacts/1580589160

API Coverage

Before After Δ
Covered (%) 476 (46.62 %) 476 (46.62 %) 0 (0 %)
Uncovered (%) 545 (53.38 %) 545 (53.38 %) 0 (0 %)
Unknown 24 24 0

@dblock dblock added skip-changelog No need to update CHANGELOG. and removed skip-changelog No need to update CHANGELOG. labels Jun 7, 2024
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the validate-order-of-superseded-operations branch from 38fd216 to fa888fc Compare June 7, 2024 20:39
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the validate-order-of-superseded-operations branch from fa888fc to cb902b6 Compare June 7, 2024 20:40
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@Xtansia Xtansia merged commit 362c90c into opensearch-project:main Jun 9, 2024
9 checks passed
@dblock dblock deleted the validate-order-of-superseded-operations branch June 10, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Check order of methods in spec
2 participants