-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganized tests and added tests for _doc. #331
Conversation
Signed-off-by: dblock <dblock@amazon.com>
Changes AnalysisCommit SHA: cf8d641 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9465079248/artifacts/1589424287 API Coverage
|
9aeeb28
to
e66f785
Compare
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@@ -155,7 +155,7 @@ To assure the correctness of the spec, you must add tests for the spec in the [t | |||
- chapters: These are the operations that are being tested. | |||
- epilogues: These are the operations that are executed after the test story is run. They are used to clean up the environment after the test story. | |||
|
|||
Below is the simplified version of the test story that tests the [index operations](tests/index.yaml): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the operations tested in the index lifecycle story is actually part of the indices
namespace. I think we should put it in tests/indices/lifecycle.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to organize tests in namespaces, updated and added to DEVELOPER_GUIDE.
Signed-off-by: dblock <dblock@amazon.com>
Description
_doc
, adding the missing 201 response.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.