Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized tests and added tests for _doc. #331

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 10, 2024

Description

  1. Reorganized tests to match spec.
  2. Added tests for POST/PUT/DELETE _doc, adding the missing 201 response.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
Copy link
Contributor

github-actions bot commented Jun 10, 2024

Changes Analysis

Commit SHA: cf8d641
Comparing To SHA: 362c90c

API Changes

Summary

├─┬Paths
│ ├─┬/{index}/_doc/{id}
│ │ ├─┬PUT
│ │ │ └─┬Responses
│ │ │   └──[➕] codes (23592:7)
│ │ └─┬POST
│ │   └─┬Responses
│ │     └──[➕] codes (23592:7)
│ └─┬/{index}/_doc
│   └─┬POST
│     └─┬Responses
│       └──[➕] codes (23592:7)
└─┬Components
  └──[➕] responses (23592:7)

Document Element Total Changes Breaking Changes
paths 3 0
components 1 0
  • Total Changes: 4
  • Additions: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9465079248/artifacts/1589424287

API Coverage

Before After Δ
Covered (%) 476 (46.62 %) 476 (46.62 %) 0 (0 %)
Uncovered (%) 545 (53.38 %) 545 (53.38 %) 0 (0 %)
Unknown 24 24 0

@dblock dblock force-pushed the more-tests branch 2 times, most recently from 9aeeb28 to e66f785 Compare June 10, 2024 19:47
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@@ -155,7 +155,7 @@ To assure the correctness of the spec, you must add tests for the spec in the [t
- chapters: These are the operations that are being tested.
- epilogues: These are the operations that are executed after the test story is run. They are used to clean up the environment after the test story.

Below is the simplified version of the test story that tests the [index operations](tests/index.yaml):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the operations tested in the index lifecycle story is actually part of the indices namespace. I think we should put it in tests/indices/lifecycle.yaml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to organize tests in namespaces, updated and added to DEVELOPER_GUIDE.

Signed-off-by: dblock <dblock@amazon.com>
@nhtruong nhtruong merged commit 62ff8e3 into opensearch-project:main Jun 11, 2024
7 checks passed
@dblock dblock deleted the more-tests branch June 11, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants