Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eslint-plugin-eslint-comments. #333

Merged

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 11, 2024

Description

  • Added https://github.com/mysticatea/eslint-plugin-eslint-comments.
  • Turned on --report-unused-disable-directives to show unused directives, removed those.
  • Standardized and sorted imports in eslint.config.mjs.
  • Added license to the generated story types file and disabled only those eslint directives that are relevant.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the eslint-plugin-eslint-comments branch from 1951a1d to 19d7af4 Compare June 11, 2024 17:04
Copy link
Contributor

github-actions bot commented Jun 11, 2024

Changes Analysis

Commit SHA: 19d7af4
Comparing To SHA: 62ff8e3

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9469823936/artifacts/1590634885

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@dblock dblock mentioned this pull request Jun 11, 2024
@Xtansia Xtansia merged commit ababab0 into opensearch-project:main Jun 11, 2024
9 checks passed
@dblock dblock deleted the eslint-plugin-eslint-comments branch June 12, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants