Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distribution field to OpenSearchVersionInfo #336

Merged

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Jun 12, 2024

Description

Adds missing distribution field to OpenSearchVersionInfo

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia force-pushed the fix/opensearchversioninfo-distribution branch from 2b94230 to a4f9038 Compare June 12, 2024 04:03
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.82%. Comparing base (ababab0) to head (a4f9038).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   79.82%   79.82%           
=======================================
  Files          45       45           
  Lines        1368     1368           
  Branches      316      278   -38     
=======================================
  Hits         1092     1092           
- Misses        255      276   +21     
+ Partials       21        0   -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 12, 2024

Changes Analysis

Commit SHA: a4f9038
Comparing To SHA: ababab0

API Changes

Summary


└─┬Components
  └─┬_common:OpensearchVersionInfo
    ├──[➕] required (26810:11)❌ 
    └──[➕] properties (26795:9)

Document Element Total Changes Breaking Changes
components 2 1
  • BREAKING Changes: 1 out of 2
  • Additions: 2
  • Breaking Additions: 1

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9476516112/artifacts/1592228813

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@dblock
Copy link
Member

dblock commented Jun 12, 2024

I opened #338 so we can catch these.

@dblock dblock merged commit ed05f56 into opensearch-project:main Jun 12, 2024
11 checks passed
@Xtansia Xtansia deleted the fix/opensearchversioninfo-distribution branch June 12, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants