Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for application/x-ndjson and tests for _bulk. #355

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 21, 2024

Description

Adds support for application/x-ndjson and tests for _bulk.

Corrects _bulk schema, when using oneOf it means "one and only one", but _bulk allows rows of JSON data that are just type: object, so multiple rows match. The error from this is as follows, telling you that multiple schemas passed validation.

[INFO] & [
  {
    "instancePath": "/items/0/create/_id",
    "schemaPath": "#/properties/_id/oneOf",
    "keyword": "oneOf",
    "params": {
      "passingSchemas": [
        0,
        1
      ]
    },
    "message": "must match exactly one schema in oneOf"
  }
]

Adds tests for tools/src/tester/ChapterReader.ts.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jun 21, 2024

Changes Analysis

Commit SHA: 7549e75
Comparing To SHA: 6e4c7ba

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9638215458/artifacts/1629826251

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@dblock dblock force-pushed the bulk-tests branch 2 times, most recently from 6b42d92 to 04005f4 Compare June 21, 2024 17:33
@dblock dblock marked this pull request as ready for review June 21, 2024 17:33
@dblock dblock force-pushed the bulk-tests branch 4 times, most recently from 2c51159 to 487c012 Compare June 21, 2024 18:05
Signed-off-by: dblock <dblock@amazon.com>
Xtansia
Xtansia previously approved these changes Jun 24, 2024
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia merged commit 6083bf5 into opensearch-project:main Jun 24, 2024
9 checks passed
@dblock dblock deleted the bulk-tests branch June 24, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants