-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing required fields #365
Conversation
Thanks! This is a good start, keep iterating on the test for a basic nodes info response. Please amend your commit for DCO with |
Changes AnalysisCommit SHA: 3e72602 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9773874899/artifacts/1663862925 API Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test doesn't seem to have the right path. Run it, make sure it fails without your fix and passes with it.
tests/_core/nodes.yaml
Outdated
description: Test nodes endpoints. | ||
chapters: | ||
- synopsis: Nodes with a json response. | ||
path: /_cat/aliases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be _nodes
.
Looks like a legit spec test failure. |
Signed-off-by: Bzil <bzchap@gmail.com>
Signed-off-by: Bzil <bzchap@gmail.com>
Signed-off-by: Bzil <bzchap@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turned out to be a lot more than just a required/optional field! Good work.
Want to try and add tests/fix the remainder of nodes API? :)
Indeed, I will try to do this, but it's will depend of my time/work |
Description
Related to issue opensearch-project/opensearch-java#1040
Issues Resolved
Bug
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.