Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: /{index}/_open can return a task. #376

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 3, 2024

Description

Fix: /{index}/_open can return a task.

[INFO] => POST /movies/_open ({
  "allow_no_indices": true,
  "expand_wildcards": "all",
  "ignore_unavailable": true,
  "wait_for_active_shards": 0,
  "cluster_manager_timeout": "30s",
  "timeout": "30s",
  "wait_for_completion": false,
  "task_execution_timeout": "1m"
}) [application/json] | undefined
[INFO] <= 200 (application/json; charset=UTF-8) | {
  "task": "AxMXH1pnQ1ay-IxPWKZezg:43594"
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jul 3, 2024

Changes Analysis

Commit SHA: f72d68d
Comparing To SHA: cbc0b08

API Changes

Summary

└─┬Paths
  └─┬/{index}/_open
    └─┬POST
      └─┬Responses
        └─┬200
          └─┬application/json
            └─┬Schema
              ├──[➖] required (24161:17)❌ 
              ├──[➖] required (24162:17)❌ 
              ├──[➖] type (24154:19)❌ 
              ├──[➖] properties (24156:15)❌ 
              ├──[➖] properties (24158:15)❌ 
              ├──[➕] oneOf (24155:17)
              └──[➕] oneOf (24160:17)

Document Element Total Changes Breaking Changes
paths 7 5
  • BREAKING Changes: 5 out of 7
  • Removals: 5
  • Additions: 2
  • Breaking Removals: 5

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9784000614/artifacts/1665492999

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@dblock dblock force-pushed the indices-open-close branch 3 times, most recently from ac3484a to 6cc3082 Compare July 3, 2024 19:50
Signed-off-by: dblock <dblock@amazon.com>
@nhtruong nhtruong merged commit 75c3704 into opensearch-project:main Jul 3, 2024
9 checks passed
@dblock dblock deleted the indices-open-close branch July 3, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants