-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strict_allow_templates option for the dynamic mapping parameter #408
Conversation
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Changes AnalysisCommit SHA: 15a9826 API ChangesSummary
ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10061341381/artifacts/1730976728 API Coverage
|
Signed-off-by: gaobinlong <gbinlong@amazon.com>
The code PR of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test into tests. You should be able to write one for the runtime
change (it's a bug!), but for the new parameter you'll need to run against a newer version of OpenSearch locally.
CHANGELOG.md
Outdated
@@ -38,6 +38,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
- Added `concurrent_query_*` and `search_idle_reactivate_count_total` fields to `SearchStats` ([#395](https://github.com/opensearch-project/opensearch-api-specification/pull/395)) | |||
- Added `remote_store` to `TranslogStats` ([#395](https://github.com/opensearch-project/opensearch-api-specification/pull/395)) | |||
- Added `file` to `/_cache/clear` and `/{index}/_cache/clear` ([#396](https://github.com/opensearch-project/opensearch-api-specification/pull/396)) | |||
- Add strict_allow_templates option for the dynamic mapping parameter ([#408](https://github.com/opensearch-project/opensearch-api-specification/pull/408)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quote strict_allow_templates
.
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Update CI to a newer 2.16 build that has your feature and it should all go 🟢 ? |
I think so. |
I mean you can do it in this PR and we can merge. |
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Spec Test Coverage Analysis
|
@dblock I've updated the image version, now all checks have passed yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job.
If you want to do more, maybe move the template tests into a subfolder, so |
Sure, I'll do that later. |
Description
Add
strict_allow_templates
option for the dynamic mapping parameter, and remove the unsupported optionruntime
.Issues Resolved
#407
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.