Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against OpenSearch 1.3.17. #424

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 16, 2024

Description

This passes tests against OpenSearch 1.x.

Since 1.x is still supported I think we should also support it in the spec. Clients can choose to ignore anything that's x-version-removed=2.0. This gives us a way to evolve backwards incompatible changes in 3.0.

The other option is a 1.x branch and we can have backports. It's possibly easier, and so if you think it's better, then I can PR spec and tests with >= 2.0 separately so that the diff is smaller, and make a 1.x branch.

WDYT @nhtruong @Xtansia ?

Issues Resolved

Part of #84.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jul 16, 2024

Changes Analysis

Commit SHA: 7476fae
Comparing To SHA: 9c15bbf

API Changes

Summary

└─┬Components
  ├──[➕] schemas (27929:7)
  ├─┬_core.search:Hit
  │ └──[➕] properties (37978:9)
  ├─┬_common:WriteResponseBase
  │ └──[➕] properties (28011:9)
  ├─┬cat.health:HealthRecord
  │ └──[➕] properties (38813:9)
  ├─┬_core.get:GetResult
  │ └──[➕] properties (36893:9)
  └─┬_core.bulk:ResponseItem
    └──[➕] properties (36667:9)

Document Element Total Changes Breaking Changes
components 6 0
  • Total Changes: 6
  • Additions: 6

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9960862929/artifacts/1707284013

API Coverage

Before After Δ
Covered (%) 483 (47.31 %) 483 (47.31 %) 0 (0 %)
Uncovered (%) 538 (52.69 %) 538 (52.69 %) 0 (0 %)
Unknown 24 24 0

@nhtruong
Copy link
Collaborator

nhtruong commented Jul 16, 2024

This is fine. The changes between major versions we see now are mainly adding and removing components so this works.
We'll split 1x into its own branch once it becomes a burden. Right now we're still adding more features for the tools and tests into the spec, so we should wait awhile before making 1x branch or we will have to backport a lot.

Signed-off-by: dblock <dblock@amazon.com>
@nhtruong nhtruong merged commit 0c59033 into opensearch-project:main Jul 16, 2024
11 checks passed
@dblock dblock deleted the opensearch-1.3.17 branch July 16, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants