Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for request headers. #461

Merged
merged 3 commits into from
Aug 4, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 1, 2024

Description

Instead of adding request_headers which would look odd, this changes request_body to request that can take a content-type, headers and/or a payload.

Issues Resolved

Closes #438.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Changes Analysis

Commit SHA: 0f50672
Comparing To SHA: 13a603c

API Changes

Summary

NO CHANGES

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10239953631/artifacts/1774265053

API Coverage

Before After Δ
Covered (%) 510 (49.95 %) 510 (49.95 %) 0 (0 %)
Uncovered (%) 511 (50.05 %) 511 (50.05 %) 0 (0 %)
Unknown 24 24 0

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Spec Test Coverage Analysis

Total Tested
534 118 (22.1 %)

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@dblock
Copy link
Member Author

dblock commented Aug 4, 2024

@nhtruong @Xtansia rebased, ready

@dblock dblock force-pushed the request-headers branch 3 times, most recently from 340cca2 to 06884d5 Compare August 4, 2024 23:03
Signed-off-by: dblock <dblock@amazon.com>
@Xtansia Xtansia merged commit 59a7ff4 into opensearch-project:main Aug 4, 2024
15 checks passed
@dblock dblock deleted the request-headers branch August 5, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for passing headers when writing tests
2 participants